Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Einsum layer #3710

Merged
1 commit merged into from
Mar 5, 2024
Merged

added Einsum layer #3710

1 commit merged into from
Mar 5, 2024

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Feb 23, 2024

Added Einsum layer. See API docs here.

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 35.00000% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 58.56%. Comparing base (c83ee86) to head (8e56442).
Report is 27 commits behind head on main.

Files Patch % Lines
flax/linen/linear.py 35.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3710      +/-   ##
==========================================
- Coverage   59.10%   58.56%   -0.55%     
==========================================
  Files         103      103              
  Lines       12426    12419       -7     
==========================================
- Hits         7345     7273      -72     
- Misses       5081     5146      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 295 to 296
>>> params = layer.init(jax.random.key(0), jnp.ones((3, 4, 5)))
>>> jax.tree_map(jnp.shape, params)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use canonical variables name

Suggested change
>>> params = layer.init(jax.random.key(0), jnp.ones((3, 4, 5)))
>>> jax.tree_map(jnp.shape, params)
>>> variables = layer.init(jax.random.key(0), jnp.ones((3, 4, 5)))
>>> jax.tree_map(jnp.shape, variables)

@copybara-service copybara-service bot closed this pull request by merging all changes into google:main in 49a8dde Mar 5, 2024
@chiamp chiamp deleted the einsum branch March 5, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants