Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tabulate's compute_flops #3721

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix Tabulate's compute_flops #3721

merged 1 commit into from
Feb 26, 2024

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Feb 26, 2024

What does this PR do?

Returns 0 when cost analysis is not available.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 59.09%. Comparing base (83e7466) to head (5ff27fd).

Files Patch % Lines
flax/linen/summary.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3721      +/-   ##
==========================================
- Coverage   59.10%   59.09%   -0.01%     
==========================================
  Files         103      103              
  Lines       12454    12456       +2     
==========================================
  Hits         7361     7361              
- Misses       5093     5095       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit f5c48fe into main Feb 26, 2024
21 checks passed
@copybara-service copybara-service bot deleted the fix-tabulate-flops branch February 26, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants