[nnx] Pytrees are Trees #3768
Merged
[nnx] Pytrees are Trees #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
nnx-improve-graph-update
branch
2 times, most recently
from
7694ab8 to
c8cf3f5
Compare
cgarciae
force-pushed
the
nnx-pytree-are-trees
branch
from
32c5836 to
4aa5ed2
Compare
cgarciae
force-pushed
the
nnx-pytree-are-trees
branch
from
4aa5ed2 to
e854b48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3768 +/- ##
==========================================
+ Coverage 59.49% 59.50% +0.01%
==========================================
Files 101 101
Lines 12623 12595 -28
==========================================
- Hits 7510 7495 -15
+ Misses 5113 5100 -13 ☔ View full report in Codecov by Sentry. |
cgarciae
force-pushed
the
nnx-pytree-are-trees
branch
from
e854b48 to
7317d9b
Compare
superbobry
approved these changes
Mar 20, 2024
| @@ -113,34 +113,25 @@ def init(self, node: Node, items: tuple[tuple[str, Leaf], ...]): | |||
|
|
|||
|
|
|||
| @dataclasses.dataclass(frozen=True) | |||
| class ImmutableNodeImpl(NodeImplBase[Node, Leaf, AuxData]): | |||
There was a problem hiding this comment.
Nit: maybe use PyTree instead of Pytree to match the capitalization in JAX?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
list,dict, andtupleare no longer graph nodes, they are they are supported as tree nodes.Other changes
MutableNodeImpltoGraphNodeImpl.ImmutableNodeImpltoPytreeNodeImpl.SequencetoListfor consistency and removes the__call__method.Sequentialthat inherits formListand implements__call__.