-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nnx] non-str State keys #3802
Merged
Merged
[nnx] non-str State keys #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
nnx-graph-non-str-keys
branch
3 times, most recently
from
March 30, 2024 13:10
0a6b17e
to
3eea173
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cgarciae
force-pushed
the
nnx-graph-non-str-keys
branch
2 times, most recently
from
March 30, 2024 13:18
89d33e0
to
c987dbb
Compare
cgarciae
force-pushed
the
nnx-graph-non-str-keys
branch
2 times, most recently
from
March 30, 2024 18:41
59ffe8d
to
cc53978
Compare
cgarciae
force-pushed
the
nnx-graph-non-str-keys
branch
from
March 30, 2024 23:29
cc53978
to
60a2e02
Compare
cgarciae
force-pushed
the
nnx-static-goes-first
branch
from
March 30, 2024 23:34
fc6c901
to
5f99f11
Compare
cgarciae
force-pushed
the
nnx-graph-non-str-keys
branch
from
March 30, 2024 23:35
60a2e02
to
64b8c7d
Compare
cgarciae
force-pushed
the
nnx-static-goes-first
branch
from
April 1, 2024 17:03
5f99f11
to
8189596
Compare
cgarciae
force-pushed
the
nnx-graph-non-str-keys
branch
from
April 1, 2024 17:05
64b8c7d
to
f08c285
Compare
cgarciae
force-pushed
the
nnx-static-goes-first
branch
from
April 1, 2024 18:22
8189596
to
1739c52
Compare
cgarciae
force-pushed
the
nnx-graph-non-str-keys
branch
from
April 1, 2024 18:23
f08c285
to
25c0e68
Compare
chiamp
approved these changes
Apr 1, 2024
cgarciae
force-pushed
the
nnx-graph-non-str-keys
branch
from
April 1, 2024 19:36
25c0e68
to
1d5f718
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3802 +/- ##
=======================================
Coverage 60.34% 60.34%
=======================================
Files 101 101
Lines 12862 12875 +13
=======================================
+ Hits 7761 7769 +8
- Misses 5101 5106 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
list
andtuple
. In general they can emit any type that implement theKey
protocol, which is anyHashable
object that also implements__lt__
.State
now containsKey
keys.State.flat_state
now returns adict[tuple[Key, ...], Any]
instead ofdict[str, Any]
with keys as/
separated strings.State.from_flat_path
now creates aState
from adict[tuple[Key, ...], Any]
._graph_node_*
functions are now methods ofGraphNode
.List
now emitsint
keys. To implement the graph node protocol correctly it overrides a couple of_graph_node_*
methods.graph_pop
bug.