Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] remove pytreelib #3816

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[nnx] remove pytreelib #3816

merged 1 commit into from
Apr 10, 2024

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Apr 2, 2024

What does this PR do?

Removes pytreelib which is no longer used as TrainState is now implemented using flax.struct.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.17%. Comparing base (5d9fd9f) to head (4570682).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3816      +/-   ##
==========================================
- Coverage   60.86%   60.17%   -0.70%     
==========================================
  Files         105      103       -2     
  Lines       13045    12795     -250     
==========================================
- Hits         7940     7699     -241     
+ Misses       5105     5096       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgarciae cgarciae force-pushed the nnx-remove-treelib branch 2 times, most recently from 1573191 to 4570682 Compare April 2, 2024 15:32
@copybara-service copybara-service bot merged commit f161a4f into main Apr 10, 2024
21 checks passed
@copybara-service copybara-service bot deleted the nnx-remove-treelib branch April 10, 2024 17:29
chiamp pushed a commit to chiamp/flax that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants