Share nnx node registry between threads #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeilGirdhar
force-pushed
the
fix_threading
branch
2 times, most recently
from
51c9895
to
f724d99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3901 +/- ##
==========================================
+ Coverage 60.43% 60.47% +0.03%
==========================================
Files 105 105
Lines 13263 13276 +13
==========================================
+ Hits 8015 8028 +13
Misses 5248 5248 ☔ View full report in Codecov by Sentry. |
cgarciae
approved these changes
May 3, 2024
chiamp
pushed a commit
to chiamp/flax
that referenced
this pull request
May 7, 2024
PiperOrigin-RevId: 630432840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a complete fix, but this fixes some of #3899