[NVIDIA] Rename fp8 custom dtype to fp32_max_grad
#3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvyZX
approved these changes
Jul 2, 2024
|
LGTM - please rebase and clear the CI test checks then I can merge it. |
kaixih
force-pushed
the
rename_fp8_custom_dtype
branch
from
244f206
to
798cfe7
Compare
|
@IvyZX Thanks for the comments. Just resolved the conflict. PTAL. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3984 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 106 107 +1
Lines 13582 13761 +179
======================================
- Misses 13582 13761 +179 ☔ View full report in Codecov by Sentry. |
|
@IvyZX Any updates? Do I need to do anything to trigger the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the original
fm32tofp32_max_gradto express the idea of the dtype is used for storing fp32 values and using max for the gradient accumulation.cc. @nouiz