Support linen.LogicallyPartitioned <-> nnx.Variable #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvyZX
changed the title
IvyZX
changed the title
IvyZX
force-pushed
the
bdg-logic
branch
2 times, most recently
from
fdb4e73
to
821bc64
Compare
IvyZX
requested review from
cgarciae and
levskaya
and removed request for
cgarciae
cgarciae
reviewed
Sep 10, 2024
flax/core/meta.py
Outdated
Comment on lines
294
to
295
| metadata['sharding'] = metadata['names'] | ||
| del metadata['names'] |
There was a problem hiding this comment.
Suggested change
| metadata['sharding'] = metadata['names'] | |
| del metadata['names'] | |
| metadata['sharding'] = metadata.pop('names') |
cgarciae
reviewed
Sep 10, 2024
flax/core/meta.py
Outdated
| """Given a dict of `nnx.Variable` format metadata, create a `nn.Partitioned`.""" | ||
| metadata['names'] = metadata['sharding'] | ||
| del metadata['sharding'] | ||
| fields = [x.name for x in dataclasses.fields(cls)] |
There was a problem hiding this comment.
feels like fields should be set
There was a problem hiding this comment.
I think dataclasses.fields should already return de-duplicated names, otherwise the class cannot be built... but yeah we can add it
There was a problem hiding this comment.
oh I mean because in the line below we just use it to check for membership
cgarciae
reviewed
Sep 10, 2024
flax/linen/spmd.py
Outdated
| """Given a dict of `nnx.Variable` format metadata, create a `nn.LogicallyPartitioned`.""" | ||
| metadata['names'], metadata['rules'] = metadata['sharding'], metadata['sharding_rules'] | ||
| del metadata['sharding'], metadata['sharding_rules'] | ||
| fields = [x.name for x in dataclasses.fields(cls)] |
cgarciae
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nnx.spmdAPI will now recognize anothernnx.Variablefield:sharding_ruleslinen.LogicallyPartitionedboxes and convert them to this format.