Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redirects for Linen guide links in the NNX site scope. #4242

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add redirects for Linen guide links in the NNX site scope. #4242

merged 1 commit into from
Oct 1, 2024

Conversation

IvyZX
Copy link
Collaborator

@IvyZX IvyZX commented Oct 1, 2024 •
edited
Loading

This prepares for the site flip of flax-nnx scope becoming flax scope.

@IvyZX IvyZX changed the title Testing out two different ways to add redirects for Linen links. Add redirects for Linen guide links in the NNX site scope. Oct 1, 2024
@IvyZX IvyZX requested a review from cgarciae October 1, 2024 20:44
levskaya
levskaya approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@levskaya levskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've checked that the redirect is snappy?

@IvyZX
Copy link
Collaborator Author

IvyZX commented Oct 1, 2024

we've checked that the redirect is snappy?

Yeah it jumps automatically for me on Chrome

@copybara-service copybara-service bot merged commit 9c162ab into google:main Oct 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levskaya levskaya levskaya approved these changes

@cgarciae cgarciae Awaiting requested review from cgarciae

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvyZX @levskaya