Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devcontainer setup #4299

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

jorisSchaller
Copy link
Contributor

@jorisSchaller jorisSchaller commented Oct 15, 2024

What does this PR do?

Fixes #4298
This PR fix the dev container setup.
It

  • bumps the python version from 3.7 to 3.12
  • Install scikit-learn with the correct name (scikit-learn and not sklearn)
  • Correct the flax path

Checklist

  • This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
    checks if that's the case).
  • This change is discussed in this issue
  • The documentation and docstrings adhere to the
    documentation guidelines.
  • This change includes necessary high-coverage tests.
    (No quality testing = no merge!)

Copy link

google-cla bot commented Oct 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jorisSchaller jorisSchaller marked this pull request as ready for review October 15, 2024 15:02
@copybara-service copybara-service bot merged commit 764e173 into google:main Oct 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev container is outdated
2 participants