Feature/delete cascade #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnoack
reviewed
Apr 11, 2024
DB-PRUNING.md
Outdated
| @@ -60,11 +60,11 @@ mysql> show tables; | |||
|
|
|||
| Conveniently the auxiliary tables contain [ON DELETE CASCADE referential actions](https://dev.mysql.com/doc/refman/8.3/en/create-table-foreign-keys.html#foreign-key-referential-actions) on the respective [FOREIGN KEYS](https://dev.mysql.com/doc/refman/8.3/en/create-table-foreign-keys.html). | |||
|
|
|||
| Therefore, we can focus on pruning rows from the three 'main' tables (```clients```,```messages``` and ```broadcasts```) to wip our Fleetspeak database back in shape. MySQL will ensure that the related tables and their entries will get cleared up accordingly. | |||
| Therefore, we can focus on pruning rows from the three 'main' tables (```clients```,```messages``` and ```broadcasts```) to wip our Fleetspeak database back into shape. MySQL will ensure that the related tables and their entries will get cleaned up accordingly. | |||
There was a problem hiding this comment.
There is also a typo in "wip" (but maybe it would be better to just use a different word ;-))
There was a problem hiding this comment.
Great catch. Thanks heaps.
Will update accordingly.
gnoack
reviewed
Apr 11, 2024
| @@ -87,11 +87,11 @@ mysql> DESCRIBE clients; | |||
|
|
|||
| ### 3.2. Pruning clients | |||
|
|
|||
| In the example ```DELETE``` command below we delete all the rows that have been created 148h (7 days) ago or older. Feel free to adjust the time according to your needs. | |||
| With the example ```DELETE``` command below we delete all the rows that have been created 168h (7 days) ago or older. Feel free to adjust the time according to your needs. | |||
There was a problem hiding this comment.
good catch with the number! o_O
|
This seems OK to me, although I am not a MySQL expert, admittedly. If there are points where you are unsure, I'd suggest looping in @torsm ; otherwise we can also go ahead with it |
gnoack
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to introduce ON DELETE CASCADE referential actions on the auxiliary tables to enable database pruning.
See the new DB-PRUNINIG.md file with a description on how the proposed database pruning could be achieved leveraging the delete cascade relations.