Unblock publication of Georama

[davelab6]

https://github.com/google/fonts/pull/2578/files was merged, but is blocked from publication:

georama's OS_2 weight class (400) doesn't match with default outline location (100).

This will also effect METADATA

[RosaWagner]

Noted.
Questions:
A. I never unblocked a publication: (1.) it consist in merging the modifications in the same PR, or (2) I create a new branch since the PR is merged anyway?
B. The fonts have to be (1) reexported with correct usWeightClass, or (2) do you prefer a hotfix?

[m4rc1e]

georama's OS_2 weight class (400) doesn't match with default outline location (100).

We've had this issue before fonttools/fontbakery#2683. The solution was to set the METADATA.pb weigthClass value to 400. We've done exactly the same thing for Georama so I cannot see why this is being flagged. We also update FB and gftools to do this automatically.

[thlinard]

Although the version number is the same, the files of #2578 are behind the upstream repo: they don't have the fix for productiontype/Georama#4, while the upstream VFs have it.

[davelab6]

fonts/ofl/georama/METADATA.pb

Line 9 in e24965e

weight: 400

has it set to 400

[davelab6]

@RosaWagner a. Unblocking publication just means that this seemed ready to go live but got stuck at he last stage, so it's a priority to do the last fixes and get it finished. 1. The pr was merged, so more can't be added there any more. More can be added to the branch that was merged and a new pr made. So you can do as you say in 2 also.

For b, I prefer re-export, but I recommend to always be in touch with upstream before doing any fixing yourself as they might volunteer to fix it themselves

[RosaWagner]

Thanks @davelab6. I have 2 questions

1. What about @m4rc1e comment:

We've had this issue before fonttools/fontbakery#2683. The solution was to set the METADATA.pb weigthClass value to 400. We've done exactly the same thing for Georama so I cannot see why this is being flagged. We also update FB and gftools to do this automatically.

2. The variable font contains width instances. So same as Newsreader: is this font special, or I should remove some instances and get in touch with @productiontype about it ?

[RosaWagner]

The binaries has also too long PS names (over 31 characters), so I would suggest to reexport it all anyway with contracted family names… Do we have a standard for that by the way ? I have seen this post fonttools/fontbakery#2179 but it doesn't really set up a standard.

[productiontype]

We usually do use short names in our own workflow, but they are known to cause stylelinking issues in some apps. After discussions on NewsReader, it was decided to implement long names in both projects. See commit productiontype/Newsreader@24d0eee See discussion short vs long on FB: fonttools/fontbakery#2179

[m4rc1e]

fonts/ofl/georama/METADATA.pb

Line 9 in e24965e

weight: 400

has it set to 400

I still don't see how this is an issue.

We currently serve Raleway which has an OS/2 usWeightClass value of 100 (default origin is Thin). While in its metadata, it has 400. Here's an FB issue which discusses the relationship between the METADATA.pb and the OS/2 VF value, fonttools/fontbakery#2683

[m4rc1e]

Sorry, I now see the issue.

The font has a default origin of 100, yet the usWeightClass is 400. the usWeightClass should be 100.