Georama 1.000 #2578

yanone · 2020-07-28T14:45:27Z

Upstream: https://github.com/productiontype/Georama
My contributions are merged as I worked directly on the repo.

m4rc1e · 2020-07-28T15:47:30Z

Fontbakery report

Fontbakery version: 0.7.29

[1] Family checks

⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

com.google.fonts/check/ftxvalidator_is_available

--- Rationale ---

There's no reasonable (and legal) way to run the command `ftxvalidator` of the
Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc.

If Font Bakery is not running on an OSX machine, the machine running Font
Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure
call (rpc).

There's an ssh example implementation at:
https://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds
/ftxvalidator/ssh-implementation/ftxvalidator

⚠ WARN Could not find ftxvalidator.

[7] Georama-Italic[wdth,wght].ttf

⚠ WARN: Check copyright namerecords match license file.

com.google.fonts/check/name/license

--- Rationale ---

A known licensing description must be provided in the NameID 14 (LICENSE
DESCRIPTION) entries of the name table.

The source of truth for this check (to determine which license is in use) is a
file placed side-by-side to your font project including the licensing terms.

Depending on the chosen license, one of the following string snippets is
expected to be found on the NameID 13 (LICENSE DESCRIPTION) entries of the name
table:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."


Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.

When in doubt, please choose OFL for new font projects.

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN For now we're still accepting http URLs, but you should consider using https instead.
[code: http]

⚠ WARN: License URL matches License text on name table?

com.google.fonts/check/name/license_url

--- Rationale ---

A known license URL must be provided in the NameID 14 (LICENSE INFO URL) entry
of the name table.

The source of truth for this check is the licensing text found on the NameID 13
entry (LICENSE DESCRIPTION).

The string snippets used for detecting licensing terms are:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."


Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.

When in doubt, please choose OFL for new font projects.

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
⚠ WARN For now we're still accepting http URLs, but you should consider using https instead.
[code: http]

⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?

com.google.fonts/check/metadata/listed_on_gfonts
⚠ WARN Family not found via Google Fonts API. [code: not-found]

⚠ WARN: Are there caret positions declared for every ligature?

com.google.fonts/check/ligature_carets

--- Rationale ---

All ligatures in a font must have corresponding caret (text cursor) positions
defined in the GDEF table, otherwhise, users may experience issues with caret
rendering.

If using GlyphsApp, ligature carets can be set directly on canvas by accessing
the `Glyph -> Set Anchors` menu option or by pressing the `Cmd+U` keyboard
shortcut.

⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences?

com.google.fonts/check/kerning_for_non_ligated_sequences

--- Rationale ---

Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).

⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
- T + h
- f + f
- f + b
- b + f
- f + h
- h + f
- f + i
- i + f
- f + j
- j + f
- f + k
- k + f
- f + l
- l + f
- f + t
- t + b
- h + i
- i + j
- j + k
- k + l
- l + t
[code: lacks-kern-info]

⚠ WARN: Check mark characters are in GDEF mark glyph class)

com.google.fonts/check/gdef_spacing_marks

--- Rationale ---

Glyphs in the GDEF mark glyph class should be non-spacing.
Spacing glyphs in the GDEF mark glyph class may have incorrect anchor
positioning that was only intended for building composite glyphs during design.

⚠ WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake:
uni0162 [code: spacing-mark-glyphs]

⚠ WARN: Check GDEF mark glyph class doesn't have characters that are not marks)

com.google.fonts/check/gdef_non_mark_chars

--- Rationale ---

Glyphs in the GDEF mark glyph class become non-spacing and may be repositioned
if they have mark anchors.
Only combining mark glyphs should be in that class. Any non-mark glyph must not
be in that class, in particular spacing glyphs.

⚠ WARN The following non-mark characters should not be in the GDEF mark glyph class:
U+0162 [code: non-mark-chars]

[5] Georama[wdth,wght].ttf

⚠ WARN: Check copyright namerecords match license file.

com.google.fonts/check/name/license

--- Rationale ---

A known licensing description must be provided in the NameID 14 (LICENSE
DESCRIPTION) entries of the name table.

The source of truth for this check (to determine which license is in use) is a
file placed side-by-side to your font project including the licensing terms.

Depending on the chosen license, one of the following string snippets is
expected to be found on the NameID 13 (LICENSE DESCRIPTION) entries of the name
table:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."


Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.

When in doubt, please choose OFL for new font projects.

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN For now we're still accepting http URLs, but you should consider using https instead.
[code: http]

⚠ WARN: License URL matches License text on name table?

com.google.fonts/check/name/license_url

--- Rationale ---

A known license URL must be provided in the NameID 14 (LICENSE INFO URL) entry
of the name table.

The source of truth for this check is the licensing text found on the NameID 13
entry (LICENSE DESCRIPTION).

The string snippets used for detecting licensing terms are:
- "This Font Software is licensed under the SIL Open Font License, Version 1.1.
This license is available with a FAQ at: https://scripts.sil.org/OFL"
- "Licensed under the Apache License, Version 2.0"
- "Licensed under the Ubuntu Font Licence 1.0."


Currently accepted licenses are Apache or Open Font License.
For a small set of legacy families the Ubuntu Font License may be acceptable as
well.

When in doubt, please choose OFL for new font projects.

⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
⚠ WARN For now we're still accepting http URLs, but you should consider using https instead.
[code: http]

⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?

com.google.fonts/check/metadata/listed_on_gfonts
⚠ WARN Family not found via Google Fonts API. [code: not-found]

⚠ WARN: Are there caret positions declared for every ligature?

com.google.fonts/check/ligature_carets

--- Rationale ---

All ligatures in a font must have corresponding caret (text cursor) positions
defined in the GDEF table, otherwhise, users may experience issues with caret
rendering.

If using GlyphsApp, ligature carets can be set directly on canvas by accessing
the `Glyph -> Set Anchors` menu option or by pressing the `Cmd+U` keyboard
shortcut.

⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences?

com.google.fonts/check/kerning_for_non_ligated_sequences

--- Rationale ---

Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).

⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
- T + h
- f + f
- f + b
- b + f
- f + h
- h + f
- f + i
- i + f
- f + j
- j + f
- f + k
- k + f
- f + l
- l + f
- f + t
- t + b
- h + i
- i + j
- j + k
- k + l
- l + t
[code: lacks-kern-info]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	0	13	71	17	239	0
0%	0%	4%	21%	5%	70%	0%

Note: The following loglevels were omitted in this report:

SKIP
INFO
PASS
DEBUG

Diff images: georama_qa.zip

m4rc1e · 2020-07-29T09:28:25Z

Thanks @yanone. I'll take a look this week.

Fyi, I'd like us to start using the gftools packager for future prs. This will make it much easier to push updates in the future.

yanone · 2020-07-29T09:29:47Z

When I'm back in October. I'm literally on my third last work day.

yanone · 2020-10-23T11:10:48Z

@RosaWagner
Why is this blocked? The only hint I can infer from above is the missing packager upstream.yaml ... Is that correct?

RosaWagner · 2020-10-23T11:32:20Z

I think Marc gave an explanation in the related issue #2650

tarrbrown

Unblock all games

yanone added 2 commits July 28, 2020 14:46

Version 1.000

62ec19f

Unhinted VFs

c08dbae

m4rc1e merged commit d8f2f5f into google:master Jul 29, 2020

thlinard mentioned this pull request Sep 1, 2020

Unblock publication of Georama #2650

Closed

RosaWagner added the blocked label Sep 9, 2020

RosaWagner added -- Needs Upstream Resolution Upstream fix required before moving forward blocked and removed blocked -- Needs Upstream Resolution Upstream fix required before moving forward labels Oct 13, 2020

tarrbrown reviewed Nov 17, 2020

View reviewed changes

RosaWagner added the I New Font label Jan 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Georama 1.000 #2578

Georama 1.000 #2578

yanone commented Jul 28, 2020

m4rc1e commented Jul 28, 2020

m4rc1e commented Jul 29, 2020

yanone commented Jul 29, 2020

yanone commented Oct 23, 2020

RosaWagner commented Oct 23, 2020

tarrbrown left a comment

Georama 1.000 #2578

Georama 1.000 #2578

Conversation

yanone commented Jul 28, 2020

m4rc1e commented Jul 28, 2020

Fontbakery report

Summary

Diff images: georama_qa.zip

m4rc1e commented Jul 29, 2020

yanone commented Jul 29, 2020

yanone commented Oct 23, 2020

RosaWagner commented Oct 23, 2020

tarrbrown left a comment

Choose a reason for hiding this comment