Update some nam files and add a few new ones. #176
Conversation
| @@ -187,7 +187,6 @@ | |||
| 0x17D9 uni17D9 | |||
| 0x17DA uni17DA | |||
| 0x17DB uni17DB | |||
| 0x17DD uni17DD | |||
Update some nam files and add a few new ones.
| 0xFBE4 # ARABIC LETTER E ISOLATED FORM | ||
| 0xFBE5 # ARABIC LETTER E FINAL FORM | ||
| 0xFBE6 # ARABIC LETTER E INITIAL FORM | ||
| 0xFBE7 # ARABIC LETTER E MEDIAL FORM | ||
| 0xFBE8 # ARABIC LETTER UIGHUR KAZAKH KIRGHIZ ALEF MAKSURA INITIAL FORM | ||
| 0xFBE9 # ARABIC LETTER UIGHUR KAZAKH KIRGHIZ ALEF MAKSURA MEDIAL FORM | ||
| 0xFBFC # ARABIC LETTER FARSI YEH ISOLATED FORM |
There was a problem hiding this comment.
I’d drop all Arabic presentation forms completely. If the font uses them in GSUB then pyftsubset (assuming that is what is used here) will keep them any way, if they are not used (like in Amiri) then you save file size. The only character that should be kept in this block is U+FDFA.
There was a problem hiding this comment.
What is fdfa for, why is it special?
There was a problem hiding this comment.
ﷺ.
Unlike the rest of the Arabic Presentation Forms blocks, this is not really a presentation form it is a symbol of its own and can’t (or shouldn’t but people may tray) to be done as a ligature. I’m not sure how wide spread its use on the web, though, Arabic Wikipedia for example uses an image probably because most system fonts have an ugly symbol for it, not what people are used to/expecting.
There was a problem hiding this comment.
That remains, so we're good :) https://github.com/google/fonts/blob/master/tools/encodings/arabic_unique-glyphs.nam#L210
There was a problem hiding this comment.
Right, I wanted to drop the rest of the block, though.
There was a problem hiding this comment.
I.e. drop 0xFB50–0xFDF2, and 0xFDFC–0xFEFC.
There was a problem hiding this comment.
@roozbehp says,
Contrary to what one may expect, the usage of the characters from the Arabic Presentation Form blocks is relatively common on the web. That's why we included them.
So, I'm okay leave this as is, and simply not drawing these characters in new fonts :)
There was a problem hiding this comment.
Not really convinced they are that popular, but I won’t argue more since I was only concerned about Amiri file size and now I remembered that I strip them away in the “web” version anyway.
There was a problem hiding this comment.
Cool - not including them is fine
No description provided.