El-Messiri: v2.009 added. #1961

eliheuer · 2019-05-03T13:50:30Z

Taken from the upstream repo https://github.com/eliheuer/El-Messiri/tree/eli-gf-mastering
at commit eliheuer/El-Messiri@594bf64

gf-bot · 2019-05-03T14:11:23Z

Fontbakery report

Fontbakery version: 0.7.3

[1] Family checks

⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

com.google.fonts/check/ftxvalidator_is_available
⚠ WARN ftxvalidator is not available.

[5] ElMessiri-Regular.ttf

💔 ERROR: Familyname must be unique according to namecheck.fontdata.com

com.google.fonts/check/fontdata_namecheck
💔 ERROR Failed to access: 'http://namecheck.fontdata.com/?q=ElMessiri'.
Please report this issue at:
https://github.com/googlefonts/fontbakery/issues

🔥 FAIL: Checking file is named canonically.

com.google.fonts/check/canonical_filename
🔥 FAIL This is a variable font, but it is using a naming scheme typical of a static font.
🔥 FAIL Please change the font filename to use one of the following valid suffixes for variable fonts: VF, Italic-VF, Roman-VF

🔥 FAIL: METADATA.pb: Filename is set canonically?

com.google.fonts/check/metadata/canonical_filename
🔥 FAIL METADATA.pb: filename field ("ElMessiri-Regular.ttf") does not match canonical name "ElMessiri-Roman-VF.ttf".

⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.

com.google.fonts/check/unitsperem_strict
⚠ WARN Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.

⚠ WARN: Glyphs are similiar to Google Fonts version?

com.google.fonts/check/production_glyphs_similarity
⚠ WARN Following glyphs differ greatly from Google Fonts version: [uniFD3F, uniFD10, uniFBFF, uniFEBA, uniFD0F, uniFD3E, uniFEF2, uni066F.medi, uniFEF6, uniFBE9, uniFD2C, uniFEFC, uniFEB7, uni06A1.medi, florin, uniFBAC, uniFBAB, uniFEB3, uni066E.medi, uniFECC, uniFEAC, uni06BE, uniFEA4, uniFB7D, uniFECA, uniFD0D, uni06A1.fina, uniFD2B, uni0634, uniFE9C, uniFECE, uniFD2A, uniFEF4, uniFB69, uniFB9F, uniFEBB, uniFE9E, uniFD0E, uniFEA8, uniFEC0, uniFD29, uniFEBE, uni0664, uni0636, uniFEEC, uniFED0, uniFEBC, uniFEB6, uni06BA.medi, uniFE8C, uniFED2, uniFEE4, uniFBFD, uniFEC4, uni0633, uniFEC8, uniFEB4, uniFEB8, uniFED8, oe, dotlesskafar.fina, uniFB6B, uniFEA6, .notdef, uniFEE0, uniFE8A, uniFEA0, uniFEEB, uniFB59, macron, uniFB6D, uniFEDA, uni06D2, uniFEA2, uniFEE2, uni0635, uniFBAD, uniFE92, uniFED4, uniFE98, uniFEC6, uniFEB2, uni06D3, uniFB89, uniFEDE, uniFEFA, uniFEF8, uniFEAA, uniFEF0, uniFEBF, uniFEE6, uniFEE8, uniFB7B, uniFEC2]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS
1	2	3	19	7	124
1%	1%	2%	12%	4%	79%

Note: The following loglevels were omitted in this report:

SKIP
INFO
PASS

Diff images: qa.zip

m4rc1e

Is Gaber happy with the modification made to the Arabic?
It appears the Arabic has lost many double marks e.g reh + shadda_fathatan
Rendering and metadata looks good!

m4rc1e · 2019-08-21T14:01:07Z

ping @eliheuer

m4rc1e · 2019-09-18T12:32:44Z

@eliheuer let us leave Lemonada for the time being and focus on this.

gf-bot · 2019-09-20T02:26:16Z

Fontbakery report

Fontbakery version: 0.7.12

[1] Family checks

⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

com.google.fonts/check/ftxvalidator_is_available
⚠ WARN ftxvalidator is not available.

[4] ElMessiri[wght].ttf

🔥 FAIL: Check glyph coverage.

com.google.fonts/check/glyph_coverage
🔥 FAIL Missing required codepoints: 0x2044 (FRACTION SLASH), 0x2074 (SUPERSCRIPT FOUR), 0x2212 (MINUS SIGN) and 0x2215 (DIVISION SLASH) [code: missing-codepoints]

⚠ WARN: Font has old ttfautohint applied?

com.google.fonts/check/old_ttfautohint
⚠ WARN ttfautohint used in font = 1.8.2; installed = 1.8.3; Need to re-run with the newer version! [code: old-ttfa]

⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.

com.google.fonts/check/unitsperem_strict
⚠ WARN Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations. [code: legacy-value]

⚠ WARN: Font contains .notdef as first glyph?

com.google.fonts/check/mandatory_glyphs
⚠ WARN Font should contain the .notdef glyph as the first glyph, it should not have a Unicode value assigned and should contain a drawing.

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	1	4	76	6	73	0
0%	1%	2%	48%	4%	46%	0%

Note: The following loglevels were omitted in this report:

SKIP
INFO
PASS
DEBUG

Diff images: qa.zip

Upstream repo: https://github.com/eliheuer/El-Messiri/tree/gf-update At commit: cf7690ac0a0f85c76510e3552c37f8b6362ba3cb

gf-bot · 2019-09-20T13:34:03Z

Fontbakery report

Fontbakery version: 0.7.12

[1] Family checks

⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?

com.google.fonts/check/ftxvalidator_is_available
⚠ WARN ftxvalidator is not available.

[4] ElMessiri[wght].ttf

🔥 FAIL: Check glyph coverage.

com.google.fonts/check/glyph_coverage
🔥 FAIL Missing required codepoints: 0x2044 (FRACTION SLASH), 0x2074 (SUPERSCRIPT FOUR), 0x2212 (MINUS SIGN) and 0x2215 (DIVISION SLASH) [code: missing-codepoints]

⚠ WARN: Font has old ttfautohint applied?

com.google.fonts/check/old_ttfautohint
⚠ WARN ttfautohint used in font = 1.8.2; installed = 1.8.3; Need to re-run with the newer version! [code: old-ttfa]

⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.

com.google.fonts/check/unitsperem_strict
⚠ WARN Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations. [code: legacy-value]

⚠ WARN: Font contains .notdef as first glyph?

com.google.fonts/check/mandatory_glyphs
⚠ WARN Font should contain the .notdef glyph as the first glyph, it should not have a Unicode value assigned and should contain a drawing.

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	1	4	76	6	73	0
0%	1%	2%	48%	4%	46%	0%

Note: The following loglevels were omitted in this report:

SKIP
INFO
PASS
DEBUG

Diff images: qa.zip

m4rc1e · 2019-09-27T09:40:44Z

LGTM

m4rc1e · 2019-09-27T09:42:50Z

Can you send a pr to Gaber's upstream please? once that's done we'll merge this.

eliheuer · 2019-09-27T14:50:28Z

Sure, I already made a upstream PR that was merged: Gue3bara/El-Messiri#18

thlinard · 2021-05-13T08:30:42Z

Why was it never in production? This VF certainly has issues, but...

eliheuer · 2021-05-13T15:01:02Z

I can still look into this and try to move it forward, It needs a gftools builder build script update anyway...

thlinard · 2021-05-13T16:24:13Z

@eliheuer For the issues (STAT table, mostly), gftools gen-stat could help.

eliheuer requested a review from m4rc1e May 3, 2019 13:50

m4rc1e requested changes May 3, 2019

View reviewed changes

eliheuer self-assigned this Jun 28, 2019

eliheuer added the III VF Replacement Replace an existing family of static fonts with variable fonts label Jun 28, 2019

m4rc1e mentioned this pull request Jul 8, 2019

elmessiri: v2.008 added #1255

Closed

eliheuer force-pushed the elmessiri branch from efa8064 to 86e0873 Compare September 20, 2019 02:14

el-messiri: v2.009 added.

2b828fc

Upstream repo: https://github.com/eliheuer/El-Messiri/tree/gf-update At commit: cf7690ac0a0f85c76510e3552c37f8b6362ba3cb

eliheuer force-pushed the elmessiri branch from 86e0873 to 2b828fc Compare September 20, 2019 13:23

m4rc1e approved these changes Sep 27, 2019

View reviewed changes

m4rc1e merged commit 4662459 into master Sep 27, 2019

m4rc1e deleted the elmessiri branch April 28, 2021 08:05

RosaWagner mentioned this pull request Jul 23, 2021

Fix remaining Multiple Designers tag #3577

Closed

11 tasks

RosaWagner added -- blocked I Font Upgrade labels Jul 23, 2021

RosaWagner mentioned this pull request Aug 6, 2021

El Messiri: Version 2.020 added #3673

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

El-Messiri: v2.009 added. #1961

El-Messiri: v2.009 added. #1961

eliheuer commented May 3, 2019

gf-bot commented May 3, 2019

m4rc1e left a comment

m4rc1e commented Aug 21, 2019

m4rc1e commented Sep 18, 2019

gf-bot commented Sep 20, 2019

gf-bot commented Sep 20, 2019

m4rc1e commented Sep 27, 2019

m4rc1e commented Sep 27, 2019

eliheuer commented Sep 27, 2019

thlinard commented May 13, 2021

eliheuer commented May 13, 2021

thlinard commented May 13, 2021

El-Messiri: v2.009 added. #1961

El-Messiri: v2.009 added. #1961

Conversation

eliheuer commented May 3, 2019

gf-bot commented May 3, 2019

Fontbakery report

Summary

Diff images: qa.zip

m4rc1e left a comment

Choose a reason for hiding this comment

m4rc1e commented Aug 21, 2019

m4rc1e commented Sep 18, 2019

gf-bot commented Sep 20, 2019

Fontbakery report

Summary

Diff images: qa.zip

gf-bot commented Sep 20, 2019

Fontbakery report

Summary

Diff images: qa.zip

m4rc1e commented Sep 27, 2019

m4rc1e commented Sep 27, 2019

eliheuer commented Sep 27, 2019

thlinard commented May 13, 2021

eliheuer commented May 13, 2021

thlinard commented May 13, 2021