Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove source keys from METADATA.pb files #2585

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Remove source keys from METADATA.pb files #2585

merged 1 commit into from
Jul 31, 2020

Conversation

andyjgf
Copy link
Contributor

@andyjgf andyjgf commented Jul 30, 2020

No description provided.

@davelab6 davelab6 changed the title Remove source from METADATA.pb Remove source keys from METADATA.pb files Jul 31, 2020
@davelab6 davelab6 merged commit 5d62754 into master Jul 31, 2020
@davelab6 davelab6 deleted the metasource branch July 31, 2020 19:34
@davelab6
Copy link
Member

This broke the staging servers as the updated protobufs definition has not propagated everywhere. This will likely be reverted in future.

cc @m4rc1e @graphicore

@felipesanches felipesanches mentioned this pull request Jul 31, 2020
Open
@davelab6 davelab6 linked an issue Aug 1, 2020 that may be closed by this pull request
Reintroduce METADATA.pb source fields whenever possible #2587
Open
@graphicore graphicore mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reintroduce METADATA.pb source fields whenever possible
2 participants
@andyjgf @davelab6