Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine glyph type #297

Merged
merged 3 commits into from
Jul 1, 2016
Merged

Determine glyph type #297

merged 3 commits into from
Jul 1, 2016

Conversation

kalapi
Copy link
Contributor

@kalapi kalapi commented Jul 1, 2016

This commit adds sub-directory with subsets of the '.nam' files. The subsets are divided by glyph types with regards to the whether a glyph is 'outline/drawn', 'composite', or 'either'.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@@ -0,0 +1,36 @@
### Glyph Type Sorting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest just appending this content to the parent directory README

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will remove it from the sub-directory for the time being and find a way to incorporate it into the parent directory's readme. Thanks!

@kalapi
Copy link
Contributor Author

kalapi commented Jul 1, 2016

@googlebot I can confirm that the sender (of this pull request) and the commit author are the same entity. I have edited my git config user.email to reflect the details in the CLA.

@davelab6
Copy link
Member

davelab6 commented Jul 1, 2016

@kalapi thanks :) I updated the contributing docs with a tip for this, googlefonts/gf-docs@7a520b4

@kalapi
Copy link
Contributor Author

kalapi commented Jul 1, 2016

Haha! Sorry about that! :)

@kalapi kalapi closed this Jul 1, 2016
@kalapi kalapi reopened this Jul 1, 2016
@davelab6 davelab6 merged commit ce99951 into google:master Jul 1, 2016
@alexeiva
Copy link
Collaborator

alexeiva commented Jul 1, 2016

The new list doesn't include caronalt > caroncomb.alt fix, possibly something other.

@davelab6
Copy link
Member

davelab6 commented Jul 1, 2016

@alexeiva please fix :)

@alexeiva
Copy link
Collaborator

alexeiva commented Jul 1, 2016

I fixed it in #302. It was the only problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants