Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Hat Mono: Version 1.010 added #3518

Merged
merged 7 commits into from
Jun 11, 2021
Merged

Conversation

RosaWagner
Copy link
Contributor

f9e0fb5: [gftools-packager] Red Hat Mono: Version 1.010 added

7187819: [gftools-packager] ofl/redhatmono remove METADATA "source". #2587

@gf-bot

This comment has been minimized.

@RosaWagner
Copy link
Contributor Author

Updated

Red Hat Mono: Version 1.010 added


6ec2f30: [gftools-packager] Red Hat Mono: Version 1.010 added

209eddf: [gftools-packager] ofl/redhatmono remove METADATA "source". #2587

@RosaWagner RosaWagner force-pushed the gftools_packager_ofl_redhatmono branch from 7187819 to 209eddf Compare June 10, 2021 17:20
@RosaWagner
Copy link
Contributor Author

  1. The instances in the fvar table are not in the right order, but after testing in several app, it doesn't mess up the dropdown menu. I do think that it should be fixed though, because we don't know how non-tested environments would react.

  2. The missing SemiBold instance has been discussing with the designer during a meeting. He is against including it. I leave @davelab6 decides if he wants to merge it anyway given that this font was prioritised, or continuing the conversation with the designer to convince him otherwise.

@RosaWagner RosaWagner linked an issue Jun 10, 2021 that may be closed by this pull request
13 tasks
@gf-bot

This comment has been minimized.

@gf-bot
Copy link

gf-bot commented Jun 10, 2021

Fontbakery report

Fontbakery version: 0.7.37

[1] Family checks
WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?
--- Rationale ---
There's no reasonable (and legal) way to run the command `ftxvalidator` of the
Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc.
If Font Bakery is not running on an OSX machine, the machine running Font Bakery
could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure call
(rpc).
There's an ssh example implementation at:
https://github.com/googlefonts/fontbakery/blob/main/prebuilt/workarounds
/ftxvalidator/ssh-implementation/ftxvalidator
  • WARN Could not find ftxvalidator. [code: ftxvalidator-available]

[7] RedHatMono-Italic[wght].ttf
🔥 FAIL: METADATA.pb: Designer is listed with the correct name on the Google Fonts catalog of designers?
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
WARN: A static fonts directory with at least two fonts must accompany variable fonts
--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure Stylistic Sets have description.
--- Rationale ---
Stylistic sets should provide description text. Programs such as InDesign,
TextEdit and Inkscape use that info to display to the users so that they know
what a given stylistic set offers.
  • WARN The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]
  • WARN The stylistic set ss02 lacks a description string on the 'name' table. [code: missing-description]
WARN: Check mark characters are in GDEF mark glyph class)
--- Rationale ---
Glyphs in the GDEF mark glyph class should be non-spacing.
Spacing glyphs in the GDEF mark glyph class may have incorrect anchor
positioning that was only intended for building composite glyphs during design.
  • WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake:
    acute, breve, caron, cedilla, circumflex, commaaccent, dieresis, dotaccent, grave, hungarumlaut and 4 more. [code: spacing-mark-glyphs]
WARN: Check GDEF mark glyph class doesn't have characters that are not marks)
--- Rationale ---
Glyphs in the GDEF mark glyph class become non-spacing and may be repositioned
if they have mark anchors.
Only combining mark glyphs should be in that class. Any non-mark glyph must not
be in that class, in particular spacing glyphs.
  • WARN The following non-mark characters should not be in the GDEF mark glyph class:
    U+0060, U+00A8, U+00AF, U+00B4, U+00B8, U+02C6, U+02C7, U+02D8, U+02D9, U+02DA, U+02DB, U+02DC and U+02DD [code: non-mark-chars]
WARN: Are there any misaligned on-curve points?
--- Rationale ---
This check heuristically looks for on-curve points which are close to, but do
not sit on, significant boundary coordinates. For example, a point which has a
Y-coordinate of 1 or -1 might be a misplaced baseline point. As well as the
baseline, here we also check for points near the x-height (but only for lower
case Latin letters), cap-height, ascender and descender Y coordinates.
Not all such misaligned curve points are a mistake, and sometimes the design may
call for points in locations near the boundaries. As this check is liable to
generate significant numbers of false positives, it will pass if there are more
than 100 reported misalignments.
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
    • Uogonek: X=353.0,Y=-1.0 (should be at baseline 0?)
    • i: X=351.0,Y=702.0 (should be at cap-height 700?)
    • j: X=444.5,Y=702.0 (should be at cap-height 700?)
    • abreve: X=232.0,Y=698.0 (should be at cap-height 700?)
    • ae: X=456.0,Y=2.0 (should be at baseline 0?)
    • ccaron: X=238.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=279.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=465.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=511.0,Y=698.0 (should be at cap-height 700?)
    • ebreve: X=225.0,Y=698.0 (should be at cap-height 700?) and 52 more. [code: found-misalignments]

[7] RedHatMono[wght].ttf
🔥 FAIL: METADATA.pb: Designer is listed with the correct name on the Google Fonts catalog of designers?
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
WARN: A static fonts directory with at least two fonts must accompany variable fonts
--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure Stylistic Sets have description.
--- Rationale ---
Stylistic sets should provide description text. Programs such as InDesign,
TextEdit and Inkscape use that info to display to the users so that they know
what a given stylistic set offers.
  • WARN The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]
  • WARN The stylistic set ss02 lacks a description string on the 'name' table. [code: missing-description]
WARN: Check mark characters are in GDEF mark glyph class)
--- Rationale ---
Glyphs in the GDEF mark glyph class should be non-spacing.
Spacing glyphs in the GDEF mark glyph class may have incorrect anchor
positioning that was only intended for building composite glyphs during design.
  • WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake:
    acute, breve, caron, cedilla, circumflex, commaaccent, dieresis, dotaccent, grave, hungarumlaut and 4 more. [code: spacing-mark-glyphs]
WARN: Check GDEF mark glyph class doesn't have characters that are not marks)
--- Rationale ---
Glyphs in the GDEF mark glyph class become non-spacing and may be repositioned
if they have mark anchors.
Only combining mark glyphs should be in that class. Any non-mark glyph must not
be in that class, in particular spacing glyphs.
  • WARN The following non-mark characters should not be in the GDEF mark glyph class:
    U+0060, U+00A8, U+00AF, U+00B4, U+00B8, U+02C6, U+02C7, U+02D8, U+02D9, U+02DA, U+02DB, U+02DC and U+02DD [code: non-mark-chars]
WARN: Are there any misaligned on-curve points?
--- Rationale ---
This check heuristically looks for on-curve points which are close to, but do
not sit on, significant boundary coordinates. For example, a point which has a
Y-coordinate of 1 or -1 might be a misplaced baseline point. As well as the
baseline, here we also check for points near the x-height (but only for lower
case Latin letters), cap-height, ascender and descender Y coordinates.
Not all such misaligned curve points are a mistake, and sometimes the design may
call for points in locations near the boundaries. As this check is liable to
generate significant numbers of false positives, it will pass if there are more
than 100 reported misalignments.
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
    • IJ: X=263.5,Y=-0.5 (should be at baseline 0?)
    • Oslash: X=520.0,Y=701.0 (should be at cap-height 700?)
    • Oslash: X=576.0,Y=701.0 (should be at cap-height 700?)
    • ccaron: X=162.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=206.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=396.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=440.0,Y=698.0 (should be at cap-height 700?)
    • ecaron: X=159.0,Y=698.0 (should be at cap-height 700?)
    • ecaron: X=203.0,Y=698.0 (should be at cap-height 700?)
    • ecaron: X=393.0,Y=698.0 (should be at cap-height 700?) and 30 more. [code: found-misalignments]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 2 13 100 17 261 0
0% 1% 3% 25% 4% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

@@ -0,0 +1,93 @@
Copyright 2018 The Fraunces Project Authors (https://github.com/undercasetype/Fraunces)
Copy link
Member

@davelab6 davelab6 Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Copyright 2021 The Red Hat Project Authors (https://github.com/RedHatOfficial/RedHatFont)

I'm curious how this other notice made its way in here :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I linked the OFL directly with packager, it is the actual file upstream. How could I miss it ?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a PR upstream

@gf-bot
Copy link

gf-bot commented Jun 10, 2021

Fontbakery report

Fontbakery version: 0.7.37

[1] Family checks
WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?
--- Rationale ---
There's no reasonable (and legal) way to run the command `ftxvalidator` of the
Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc.
If Font Bakery is not running on an OSX machine, the machine running Font Bakery
could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure call
(rpc).
There's an ssh example implementation at:
https://github.com/googlefonts/fontbakery/blob/main/prebuilt/workarounds
/ftxvalidator/ssh-implementation/ftxvalidator
  • WARN Could not find ftxvalidator. [code: ftxvalidator-available]

[8] RedHatMono-Italic[wght].ttf
🔥 FAIL: DESCRIPTION.en_us.html must have less than 1000 bytes.
🔥 FAIL: METADATA.pb: Designer is listed with the correct name on the Google Fonts catalog of designers?
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
WARN: A static fonts directory with at least two fonts must accompany variable fonts
--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure Stylistic Sets have description.
--- Rationale ---
Stylistic sets should provide description text. Programs such as InDesign,
TextEdit and Inkscape use that info to display to the users so that they know
what a given stylistic set offers.
  • WARN The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]
  • WARN The stylistic set ss02 lacks a description string on the 'name' table. [code: missing-description]
WARN: Check mark characters are in GDEF mark glyph class)
--- Rationale ---
Glyphs in the GDEF mark glyph class should be non-spacing.
Spacing glyphs in the GDEF mark glyph class may have incorrect anchor
positioning that was only intended for building composite glyphs during design.
  • WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake:
    acute, breve, caron, cedilla, circumflex, commaaccent, dieresis, dotaccent, grave, hungarumlaut and 4 more. [code: spacing-mark-glyphs]
WARN: Check GDEF mark glyph class doesn't have characters that are not marks)
--- Rationale ---
Glyphs in the GDEF mark glyph class become non-spacing and may be repositioned
if they have mark anchors.
Only combining mark glyphs should be in that class. Any non-mark glyph must not
be in that class, in particular spacing glyphs.
  • WARN The following non-mark characters should not be in the GDEF mark glyph class:
    U+0060, U+00A8, U+00AF, U+00B4, U+00B8, U+02C6, U+02C7, U+02D8, U+02D9, U+02DA, U+02DB, U+02DC and U+02DD [code: non-mark-chars]
WARN: Are there any misaligned on-curve points?
--- Rationale ---
This check heuristically looks for on-curve points which are close to, but do
not sit on, significant boundary coordinates. For example, a point which has a
Y-coordinate of 1 or -1 might be a misplaced baseline point. As well as the
baseline, here we also check for points near the x-height (but only for lower
case Latin letters), cap-height, ascender and descender Y coordinates.
Not all such misaligned curve points are a mistake, and sometimes the design may
call for points in locations near the boundaries. As this check is liable to
generate significant numbers of false positives, it will pass if there are more
than 100 reported misalignments.
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
    • Uogonek: X=353.0,Y=-1.0 (should be at baseline 0?)
    • i: X=351.0,Y=702.0 (should be at cap-height 700?)
    • j: X=444.5,Y=702.0 (should be at cap-height 700?)
    • abreve: X=232.0,Y=698.0 (should be at cap-height 700?)
    • ae: X=456.0,Y=2.0 (should be at baseline 0?)
    • ccaron: X=238.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=279.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=465.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=511.0,Y=698.0 (should be at cap-height 700?)
    • ebreve: X=225.0,Y=698.0 (should be at cap-height 700?) and 52 more. [code: found-misalignments]

[8] RedHatMono[wght].ttf
🔥 FAIL: DESCRIPTION.en_us.html must have less than 1000 bytes.
🔥 FAIL: METADATA.pb: Designer is listed with the correct name on the Google Fonts catalog of designers?
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
WARN: A static fonts directory with at least two fonts must accompany variable fonts
--- Rationale ---
Variable font family directories kept in the google/fonts git repo may include a
static/ subdir containing static fonts.
These files are meant to be served for users that still lack support for
variable fonts in their web browsers.
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure Stylistic Sets have description.
--- Rationale ---
Stylistic sets should provide description text. Programs such as InDesign,
TextEdit and Inkscape use that info to display to the users so that they know
what a given stylistic set offers.
  • WARN The stylistic set ss01 lacks a description string on the 'name' table. [code: missing-description]
  • WARN The stylistic set ss02 lacks a description string on the 'name' table. [code: missing-description]
WARN: Check mark characters are in GDEF mark glyph class)
--- Rationale ---
Glyphs in the GDEF mark glyph class should be non-spacing.
Spacing glyphs in the GDEF mark glyph class may have incorrect anchor
positioning that was only intended for building composite glyphs during design.
  • WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake:
    acute, breve, caron, cedilla, circumflex, commaaccent, dieresis, dotaccent, grave, hungarumlaut and 4 more. [code: spacing-mark-glyphs]
WARN: Check GDEF mark glyph class doesn't have characters that are not marks)
--- Rationale ---
Glyphs in the GDEF mark glyph class become non-spacing and may be repositioned
if they have mark anchors.
Only combining mark glyphs should be in that class. Any non-mark glyph must not
be in that class, in particular spacing glyphs.
  • WARN The following non-mark characters should not be in the GDEF mark glyph class:
    U+0060, U+00A8, U+00AF, U+00B4, U+00B8, U+02C6, U+02C7, U+02D8, U+02D9, U+02DA, U+02DB, U+02DC and U+02DD [code: non-mark-chars]
WARN: Are there any misaligned on-curve points?
--- Rationale ---
This check heuristically looks for on-curve points which are close to, but do
not sit on, significant boundary coordinates. For example, a point which has a
Y-coordinate of 1 or -1 might be a misplaced baseline point. As well as the
baseline, here we also check for points near the x-height (but only for lower
case Latin letters), cap-height, ascender and descender Y coordinates.
Not all such misaligned curve points are a mistake, and sometimes the design may
call for points in locations near the boundaries. As this check is liable to
generate significant numbers of false positives, it will pass if there are more
than 100 reported misalignments.
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:
    • IJ: X=263.5,Y=-0.5 (should be at baseline 0?)
    • Oslash: X=520.0,Y=701.0 (should be at cap-height 700?)
    • Oslash: X=576.0,Y=701.0 (should be at cap-height 700?)
    • ccaron: X=162.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=206.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=396.0,Y=698.0 (should be at cap-height 700?)
    • ccaron: X=440.0,Y=698.0 (should be at cap-height 700?)
    • ecaron: X=159.0,Y=698.0 (should be at cap-height 700?)
    • ecaron: X=203.0,Y=698.0 (should be at cap-height 700?)
    • ecaron: X=393.0,Y=698.0 (should be at cap-height 700?) and 30 more. [code: found-misalignments]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 4 13 100 17 259 0
0% 1% 3% 25% 4% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jun 11, 2021

LGTM. Thanks

@m4rc1e m4rc1e merged commit 485d5b6 into main Jun 11, 2021
@m4rc1e m4rc1e deleted the gftools_packager_ofl_redhatmono branch June 11, 2021 13:47
@RosaWagner RosaWagner added --- to_sandbox I Designer profile Designer profiles related stuff and removed - Ready for Review labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Designer profile Designer profiles related stuff I New Font
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Red Hat Font
4 participants