Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babylonica: Version 1.010; ttfautohint (v1.8.3) added #4324

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

vv-monsalve
Copy link
Collaborator

32cccf0: [gftools-packager] Babylonica: Version 1.010; ttfautohint (v1.8.3) added

9583bc7: [gftools-packager] ofl/babylonica remove METADATA "source". #2587

@vv-monsalve vv-monsalve linked an issue Feb 18, 2022 that may be closed by this pull request
@vv-monsalve
Copy link
Collaborator Author

Babylonica is part of Batch 5 of TypeSetIT fonts.

@gf-bot

This comment was marked as outdated.

@RosaWagner
Copy link
Contributor

This one still have the apple logo, I know you guys usually replace it by a head. @vv-monsalve shall I merge anyway?

@RosaWagner RosaWagner added -- Needs confirmation from upstream or onboarder and removed - Ready for Review labels Feb 23, 2022
@vv-monsalve
Copy link
Collaborator Author

Updated

Babylonica: Version 1.010; ttfautohint (v1.8.3) added


9ff4202: [gftools-packager] Babylonica: Version 1.010; ttfautohint (v1.8.3) added

@vv-monsalve vv-monsalve force-pushed the gftools_packager_ofl_babylonica branch from 58894a2 to 9ff4202 Compare February 24, 2022 03:02
@gf-bot
Copy link

gf-bot commented Feb 24, 2022

Fontbakery report

Fontbakery version: 0.8.7

[9] Babylonica-Regular.ttf
🔥 FAIL: Check upstream.yaml file contains all required fields
* [com.google.fonts/check/repo/upstream_yaml_has_required_fields](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/repo/upstream_yaml_has_required_fields)
--- Rationale ---
If a family has been pushed using the gftools packager, we must check that all
the required fields in the upstream.yaml file have been populated.
  • 🔥 FAIL The upstream.yaml file is missing the following fields: ['repository_url'] [code: missing-fields]
WARN: Font has old ttfautohint applied?
* [com.google.fonts/check/old_ttfautohint](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/old_ttfautohint)
--- Rationale ---
Check if font has been hinted with an outdated version of ttfautohint.
  • WARN ttfautohint used in font = 1.8.3; latest = 1.8.4; Need to re-run with the newer version! [code: old-ttfa]
WARN: Is there kerning info for non-ligated sequences?
* [com.google.fonts/check/kerning_for_non_ligated_sequences](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/kerning_for_non_ligated_sequences)
--- Rationale ---
Fonts with ligatures should have kerning on the corresponding non-ligated
sequences for text where ligatures aren't used (eg
https://github.com/impallari/Raleway/issues/14).
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f
    • f + i
    • i + f
    • f + l
    • l + f
    • i + l

    [code: lacks-kern-info]

WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table.
* [com.google.fonts/check/meta/script_lang_tags](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/googlefonts.html#com.google.fonts/check/meta/script_lang_tags)
--- Rationale ---
The OpenType 'meta' table originated at Apple. Microsoft added it to OT with
just two DataMap records:
- dlng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font is designed for
- slng: comma-separated ScriptLangTags that indicate which scripts, or languages
and scripts, with possible variants, the font supports
The slng structure is intended to describe which languages and scripts the font
overall supports. For example, a Traditional Chinese font that also contains
Latin characters, can indicate Hant,Latn, showing that it supports Hant, the
Traditional Chinese variant of the Hani script, and it also supports the Latn
script
The dlng structure is far more interesting. A font may contain various glyphs,
but only a particular subset of the glyphs may be truly "leading" in the design,
while other glyphs may have been included for technical reasons. Such a
Traditional Chinese font could only list Hant there, showing that it’s designed
for Traditional Chinese, but the font would omit Latn, because the developers
don’t think the font is really recommended for purely Latin-script use.
The tags used in the structures can comprise just script, or also language and
script. For example, if a font has Bulgarian Cyrillic alternates in the locl
feature for the cyrl BGR OT languagesystem, it could also indicate in dlng
explicitly that it supports bul-Cyrl. (Note that the scripts and languages in
meta use the ISO language and script codes, not the OpenType ones).
This check ensures that the font has the meta table containing the slng and dlng
structures.
All families in the Google Fonts collection should contain the 'meta' table.
Windows 10 already uses it when deciding on which fonts to fall back to. The
Google Fonts API and also other environments could use the data for smarter
filtering. Most importantly, those entries should be added to the Noto fonts.
In the font making process, some environments store this data in external files
already. But the meta table provides a convenient way to store this inside the
font file, so some tools may add the data, and unrelated tools may read this
data. This makes the solution much more portable and universal.
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs
* [com.google.fonts/check/unreachable_glyphs](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/unreachable_glyphs)
--- Rationale ---
Glyphs are either accessible directly through Unicode codepoints or through
substitution rules. Any glyphs not accessible by either of these means are
redundant and serve only to increase the font's file size.
  • WARN The following glyphs could not be reached by codepoint or substitution rules:
    • .null
    • eight.lf
    • two.lf
    • ringacute
    • five.lf
    • three.lf
    • zero.lf
    • four.lf
    • seven.lf
    • one.lf
    • six.lf
    • And nine.lf
      [code: unreachable-glyphs]
WARN: Check if each glyph has the recommended amount of contours.
* [com.google.fonts/check/contour_count](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/contour_count)
--- Rationale ---
Visually QAing thousands of glyphs by hand is tiring. Most glyphs can only be
constructured in a handful of ways. This means a glyph's contour count will only
differ slightly amongst different fonts, e.g a 'g' could either be 2 or 3
contours, depending on whether its double story or single story.
However, a quotedbl should have 2 contours, unless the font belongs to a display
family.
This check currently does not cover variable fonts because there's plenty of
alternative ways of constructing glyphs with multiple outlines for each feature
in a VarFont. The expected contour count data for this check is currently
optimized for the typical construction of glyphs in static fonts.
  • WARN This font has a 'Soft Hyphen' character (codepoint 0x00AD) which is supposed to be zero-width and invisible, and is used to mark a hyphenation possibility within a word in the absence of or overriding dictionary hyphenation. It is mostly an obsolete mechanism now, and the character is only included in fonts for legacy codepage coverage. [code: softhyphen]
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: numbersign	Contours detected: 4	Expected: 2
- Glyph name: dollar	Contours detected: 7	Expected: 1 or 3
- Glyph name: percent	Contours detected: 6	Expected: 5
- Glyph name: parenright	Contours detected: 2	Expected: 1
- Glyph name: zero	Contours detected: 4	Expected: 2 or 3
- Glyph name: one	Contours detected: 2	Expected: 1
- Glyph name: three	Contours detected: 2	Expected: 1
- Glyph name: seven	Contours detected: 2	Expected: 1
- Glyph name: eight	Contours detected: 5	Expected: 3
- Glyph name: at	Contours detected: 3	Expected: 2 
- And 656 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Ensure dotted circle glyph is present and can attach marks.
* [com.google.fonts/check/dotted_circle](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/universal.html#com.google.fonts/check/dotted_circle)
--- Rationale ---
The dotted circle character (U+25CC) is inserted by shaping engines before mark
glyphs which do not have an associated base, especially in the context of broken
syllabic clusters.
For fonts containing combining marks, it is recommended that the dotted circle
character be included so that these isolated marks can be displayed properly;
for fonts supporting complex scripts, this should be considered mandatory.
Additionally, when a dotted circle glyph is present, it should be able to
display all marks correctly, meaning that it should contain anchors for all
attaching marks.
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Do outlines contain any jaggy segments?
* [com.google.fonts/check/outline_jaggy_segments](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/.html#com.google.fonts/check/outline_jaggy_segments)
--- Rationale ---
This check heuristically detects outline segments which form a particularly
small angle, indicative of an outline error. This may cause false positives in
cases such as extreme ink traps, so should be regarded as advisory and backed up
by manual inspection.
  • WARN The following glyphs have jaggy segments:
    • B (U+0042): B<<442.0,457.0>-<449.0,457.0>-<447.0,455.0>>/B<<447.0,455.0>-<455.0,464.0>-<453.0,469.0>> = 3.3664606634298315
    • B (U+0042): B<<880.0,190.0>-<887.0,190.0>-<884.0,187.0>>/B<<884.0,187.0>-<892.0,193.0>-<905.0,194.0>> = 8.13010235415596
    • B (U+0042): B<<90.0,420.0>-<111.0,412.0>-<104.0,412.0>>/L<<104.0,412.0>--<112.0,414.0>> = 14.036243467926484
    • C (U+0043): B<<375.5,-54.0>-<373.0,-53.0>-<374.0,-53.0>>/B<<374.0,-53.0>-<369.0,-54.0>-<352.5,-59.5>> = 11.309932474020195
    • C (U+0043): B<<580.0,342.5>-<547.0,311.0>-<486.0,255.0>>/L<<486.0,255.0>--<495.0,261.0>> = 8.862883831696553
    • Cacute (U+0106): B<<375.5,-54.0>-<373.0,-53.0>-<374.0,-53.0>>/B<<374.0,-53.0>-<369.0,-54.0>-<352.5,-59.5>> = 11.309932474020195
    • Cacute (U+0106): B<<580.0,342.5>-<547.0,311.0>-<486.0,255.0>>/L<<486.0,255.0>--<495.0,261.0>> = 8.862883831696553
    • Ccaron (U+010C): B<<375.5,-54.0>-<373.0,-53.0>-<374.0,-53.0>>/B<<374.0,-53.0>-<369.0,-54.0>-<352.5,-59.5>> = 11.309932474020195
    • Ccaron (U+010C): B<<580.0,342.5>-<547.0,311.0>-<486.0,255.0>>/L<<486.0,255.0>--<495.0,261.0>> = 8.862883831696553
    • Ccedilla (U+00C7): B<<325.5,-54.0>-<323.0,-53.0>-<324.0,-53.0>>/B<<324.0,-53.0>-<319.0,-54.0>-<302.5,-59.5>> = 11.309932474020195 and 378 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

WARN: Do outlines contain any semi-vertical or semi-horizontal lines?
* [com.google.fonts/check/outline_semi_vertical](https://font-bakery.readthedocs.io/en/latest/fontbakery/profiles/.html#com.google.fonts/check/outline_semi_vertical)
--- Rationale ---
This check detects line segments which are nearly, but not quite, exactly
horizontal or vertical. Sometimes such lines are created by design, but often
they are indicative of a design error.
This check is disabled for italic styles, which often contain nearly-upright
lines.
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:
  • Tbar (U+0166): L<<355.0,264.0>--<495.0,265.0>> and bracketright (U+005D): L<<231.0,507.0>--<396.0,506.0>> [code: found-semi-vertical]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 8 53 9 152 0
0% 0% 4% 24% 4% 68% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • INFO
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator Author

This one still have the apple logo, I know you guys usually replace it by a head. @vv-monsalve shall I merge anyway?

We haven't been checking this on the fonts as part of the long list of confirmations for TSI projects tbh. But out of consistency, I've updated the PR.

Also, I wanted to test again the PR with packager without using the --no-source flag, and when doing so indeed the repo URL doesn't get included in the upstream.yml file as reported by FB.

Haven't adjusted it manually yet so that we could inspect this.

@RosaWagner RosaWagner added - Ready for Review and removed -- Needs confirmation from upstream or onboarder labels Feb 24, 2022
@RosaWagner
Copy link
Contributor

Also, I wanted to test again the PR with packager without using the --no-source flag, and when doing so indeed the repo URL doesn't get included in the upstream.yml file as reported by FB.

I think it's correct since the source field is in metadata.pb

@RosaWagner RosaWagner merged commit 53d6b71 into main Feb 24, 2022
@RosaWagner RosaWagner deleted the gftools_packager_ofl_babylonica branch February 24, 2022 14:09
@RosaWagner RosaWagner added --- Live Font is visible on API and removed --- to production labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- Live Font is visible on API I New Font
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Babylonica
3 participants