Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Serif Khojki: Version 2.004 added #6426

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

simoncozens
Copy link
Collaborator

aacb2d5: [gftools-packager] Noto Serif Khojki: Version 2.004 added

@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[20] NotoSerifKhojki[wght].ttf
🔥 FAIL: Checking with fontTools.ttx (com.google.fonts/check/ttx_roundtrip)
  • 🔥 FAIL name id 256 missing from name table
  • INFO While converting TTF into an XML file, ttx emited the messages listed below.
🔥 FAIL: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • 🔥 FAIL The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́ [code: soft-dotted]

🔥 FAIL: Check name table for empty records. (com.adobe.fonts/check/name/empty_records)
  • 🔥 FAIL "name" table record with key=(3, 1, 1033, 256) is empty and should be removed. [code: empty-record]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, math, tifinagh

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: syriac, coptic, old-permic, math, malayalam, tai-le, tifinagh, canadian-aboriginal

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

  • U+2010 HYPHEN: try adding one of: lisu, yi, coptic, kaithi, cham, sora-sompeng, syloti-nagri, kharoshthi, sundanese, kayah-li

  • U+261E WHITE RIGHT POINTING INDEX: try adding symbols

Or you can add the above codepoints to one of the subsets supported by the font: khojki, latin, latin-ext, menu [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • Nukta_aiMatrakhoj

    • Nukta_auMatrakhoj

    • Nukta_oMatrakhoj

    • NullMark

    • dblsectionmark.alt

    • rakar_rVocalicMatra

    • sh_ra_iMatrakhoj

    • sh_ra_iiMatrakhoj

    • sh_ra_uMatrakhoj

    • sixkhoj.alt

    • uni00A0.1
      [code: unreachable-glyphs]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font: - Contour 1 start point differs in glyph 'dd_ra_iMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3813f0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3803a0>

    • Contour 1 start point differs in glyph 'nna_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3813f0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3803a0>

    • Contour 1 start point differs in glyph 'nn_ra_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3813f0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3803a0>

    • Contour 1 start point differs in glyph 'dd_ra_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3813f0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3803a0>

    • Contour 0 start point differs in glyph 'nn_rakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3813f0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3803a0>

    • Contour 0 start point differs in glyph 'dd_rakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3813f0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3803a0>

    • Contour 1 start point differs in glyph 'dda_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3813f0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3803a0>

    • Contour 1 start point differs in glyph 'nn_ra_iMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3813f0> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f2ced3803a0> [code: interpolation-issues]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 559 among a set of 5 math glyphs.
    The following math glyphs have a different width, though:

Width = 558:
multiply, plus
[code: width-outliers]

WARN: Check GDEF mark glyph class doesn't have characters that are not marks. (com.google.fonts/check/gdef_non_mark_chars)
  • WARN The following non-mark characters should not be in the GDEF mark glyph class:
    U+11235 [code: non-mark-chars]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • parenleft (U+0028): X=284.0,Y=715.0 (should be at cap-height 714?)

    • parenright (U+0029): X=117.0,Y=715.0 (should be at cap-height 714?)

    • three (U+0033): X=334.5,Y=1.0 (should be at baseline 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at baseline 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at baseline 0?)

    • a (U+0061): X=182.0,Y=536.5 (should be at x-height 536?)

    • c (U+0063): X=360.0,Y=535.0 (should be at x-height 536?)

    • f (U+0066): X=331.0,Y=712.5 (should be at cap-height 714?)

    • g (U+0067): X=161.0,Y=-0.5 (should be at baseline 0?)

    • h (U+0068): X=66.5,Y=713.5 (should be at cap-height 714?)

    • 45 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifkhojki/NotoSerifKhojki[wght].ttf
Dehinted Size 225.1kb
Hinted Size 225.2kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.004'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.004"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifkhojki [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 3 10 45 8 180 0
0% 1% 4% 18% 3% 73% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens
Copy link
Collaborator Author

This release:

Encodes the letter "qa" (https://github.com/notofonts/khojki/issues/10)
Allows the nukta to attach to the dotted circle (https://github.com/notofonts/khojki/issues/11)
Removes the Gujarati reph (https://github.com/notofonts/khojki/issues/9)
Improves anchor positioning, including correct attachment of top matras (https://github.com/notofonts/khojki/issues/7)

@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[20] NotoSerifKhojki[wght].ttf
🔥 FAIL: Checking with fontTools.ttx (com.google.fonts/check/ttx_roundtrip)
  • 🔥 FAIL name id 256 missing from name table
  • INFO While converting TTF into an XML file, ttx emited the messages listed below.
🔥 FAIL: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • 🔥 FAIL The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́ [code: soft-dotted]

🔥 FAIL: Check name table for empty records. (com.adobe.fonts/check/name/empty_records)
  • 🔥 FAIL "name" table record with key=(3, 1, 1033, 256) is empty and should be removed. [code: empty-record]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, coptic, math, cherokee

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: malayalam, coptic, tifinagh, syriac, canadian-aboriginal, old-permic, tai-le, math

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee

  • U+2010 HYPHEN: try adding one of: coptic, kaithi, cham, sundanese, syloti-nagri, lisu, yi, kharoshthi, sora-sompeng, kayah-li

  • U+261E WHITE RIGHT POINTING INDEX: try adding symbols

Or you can add the above codepoints to one of the subsets supported by the font: khojki, latin, latin-ext, menu [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • Nukta_aiMatrakhoj

    • Nukta_auMatrakhoj

    • Nukta_oMatrakhoj

    • NullMark

    • dblsectionmark.alt

    • rakar_rVocalicMatra

    • sh_ra_iMatrakhoj

    • sh_ra_iiMatrakhoj

    • sh_ra_uMatrakhoj

    • sixkhoj.alt

    • uni00A0.1
      [code: unreachable-glyphs]

WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font: - Contour 1 start point differs in glyph 'nn_ra_iMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8190> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8220>

    • Contour 1 start point differs in glyph 'dda_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8190> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8220>

    • Contour 1 start point differs in glyph 'nna_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8190> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8220>

    • Contour 0 start point differs in glyph 'dd_rakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8190> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8220>

    • Contour 1 start point differs in glyph 'dd_ra_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8190> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8220>

    • Contour 1 start point differs in glyph 'nn_ra_iiMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8190> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8220>

    • Contour 1 start point differs in glyph 'dd_ra_iMatrakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8190> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8220>

    • Contour 0 start point differs in glyph 'nn_rakhoj' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8190> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7f70c36b8220> [code: interpolation-issues]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 559 among a set of 5 math glyphs.
    The following math glyphs have a different width, though:

Width = 558:
multiply, plus
[code: width-outliers]

WARN: Check GDEF mark glyph class doesn't have characters that are not marks. (com.google.fonts/check/gdef_non_mark_chars)
  • WARN The following non-mark characters should not be in the GDEF mark glyph class:
    U+11235 [code: non-mark-chars]
WARN: Are there any misaligned on-curve points? (com.google.fonts/check/outline_alignment_miss)
  • WARN The following glyphs have on-curve points which have potentially incorrect y coordinates:

    • parenleft (U+0028): X=284.0,Y=715.0 (should be at cap-height 714?)

    • parenright (U+0029): X=117.0,Y=715.0 (should be at cap-height 714?)

    • three (U+0033): X=334.5,Y=1.0 (should be at baseline 0?)

    • nine (U+0039): X=139.0,Y=2.0 (should be at baseline 0?)

    • G (U+0047): X=519.0,Y=1.5 (should be at baseline 0?)

    • a (U+0061): X=182.0,Y=536.5 (should be at x-height 536?)

    • c (U+0063): X=360.0,Y=535.0 (should be at x-height 536?)

    • f (U+0066): X=331.0,Y=712.5 (should be at cap-height 714?)

    • g (U+0067): X=161.0,Y=-0.5 (should be at baseline 0?)

    • h (U+0068): X=66.5,Y=713.5 (should be at cap-height 714?)

    • 45 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-misalignments]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifkhojki/NotoSerifKhojki[wght].ttf
Dehinted Size 225.1kb
Hinted Size 225.2kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.004'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.004"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifkhojki [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 3 10 45 8 180 0
0% 1% 4% 18% 3% 73% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

This was referenced Jul 28, 2023
@RosaWagner RosaWagner merged commit e7c1d79 into main Jul 28, 2023
@RosaWagner RosaWagner deleted the gftools_packager_ofl_notoserifkhojki branch July 28, 2023 14:45
@RosaWagner
Copy link
Contributor

@simoncozens There is some tofu in sandbox
Screenshot 2023-08-29 at 16 39 15

@RosaWagner RosaWagner added the --- API Tofu Show tofu in API because of missing glyphs or API issue label Aug 29, 2023
@RosaWagner
Copy link
Contributor

@simoncozens this will be pushed to prod with the next lang and metadata update

@RosaWagner RosaWagner mentioned this pull request Sep 7, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--- API Tofu Show tofu in API because of missing glyphs or API issue I Font Upgrade
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

2 participants