Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Sans NKo: Version 2.004; ttfautohint (v1.8.4.7-5d5b) added #6429

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

simoncozens
Copy link
Collaborator

9ac4112: [gftools-packager] Noto Sans NKo: Version 2.004; ttfautohint (v1.8.4.7-5d5b) added

…7-5d5b) added

* Noto Sans NKo Version 2.004; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/notofonts/nko.git at commit https://github.com/notofonts/nko/commit/.
@simoncozens simoncozens force-pushed the gftools_packager_ofl_notosansnko branch from d70352b to 9ac4112 Compare June 23, 2023 08:48
@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[17] NotoSansNKo-Regular.ttf
🔥 FAIL: Ensure METADATA.pb does not use escaped strings. (com.google.fonts/check/metadata/escaped_strings)
  • 🔥 FAIL Found escaped chars at 'Noto Sans N'Ko'. Please use an unicode string instead. [code: escaped-strings]
🔥 FAIL: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • 🔥 FAIL The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́ [code: soft-dotted]

WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, cherokee, math, tifinagh

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: coptic, syriac, tifinagh, canadian-aboriginal, math, tai-le, old-permic, malayalam

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, nko [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • uni00A0.1
      [code: unreachable-glyphs]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2 

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 572 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 322:
minus
[code: width-outliers]

WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
  • WARN The following glyphs have segments which seem very short:

    • two (U+0032) contains a short segment L<<159.0,84.0>--<159.0,80.0>>

    • at (U+0040) contains a short segment B<<613.0,293.0>-<612.0,275.0>-<612.0,267.5>>

    • at (U+0040) contains a short segment B<<612.0,267.5>-<612.0,260.0>-<612.0,257.0>>

    • M (U+004D) contains a short segment L<<177.0,626.0>--<173.0,626.0>>

    • M (U+004D) contains a short segment L<<450.0,129.0>--<454.0,129.0>>

    • N (U+004E) contains a short segment L<<176.0,593.0>--<172.0,593.0>>

    • N (U+004E) contains a short segment L<<582.0,123.0>--<586.0,123.0>>

    • Q (U+0051) contains a short segment B<<416.0,-9.0>-<410.0,-9.0>-<403.5,-9.5>>

    • Q (U+0051) contains a short segment B<<403.5,-9.5>-<397.0,-10.0>-<391.0,-10.0>>

    • W (U+0057) contains a short segment B<<468.0,577.5>-<463.0,600.0>-<461.0,609.0>>

    • 62 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • uniFD3E (U+FD3E): L<<272.0,409.0>--<273.0,459.0>> -> L<<273.0,459.0>--<273.0,583.0>> [code: found-colinear-vectors]
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notosansnko/NotoSansNKo-Regular.ttf
Dehinted Size 53.6kb
Hinted Size 77.8kb
Increase 24.2kb
Change 45.1 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.004; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notosansnko [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 2 9 65 7 163 0
0% 1% 4% 26% 3% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens
Copy link
Collaborator Author

This release:

* Adjust the size of the dorome, thanks to Neil Patel
* Reshapes the tone marks to make them easily distinguishable (#3)
* Sets above marks at a constant height (#7)
* Add spaces around Dantayalan where necessary (#5)

@RosaWagner RosaWagner added -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required I Font Upgrade labels Sep 5, 2023
@simoncozens simoncozens removed the -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required label Sep 5, 2023
@simoncozens simoncozens removed their assignment Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

FontBakery report

fontbakery version: 0.9.0a3

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[17] NotoSansNKo-Regular.ttf
🔥 FAIL: Ensure METADATA.pb does not use escaped strings. (com.google.fonts/check/metadata/escaped_strings)
  • 🔥 FAIL Found escaped chars at 'Noto Sans N'Ko'. Please use an unicode string instead. [code: escaped-strings]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, tifinagh, cherokee, math

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+0307 COMBINING DOT ABOVE: try adding one of: math, canadian-aboriginal, tai-le, tifinagh, coptic, old-permic, malayalam, syriac

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, nko [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • uni00A0.1
      [code: unreachable-glyphs]
WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 572 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 322:
minus
[code: width-outliers]

WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
  • WARN The following glyphs have segments which seem very short:

    • two (U+0032) contains a short segment L<<159.0,84.0>--<159.0,80.0>>

    • at (U+0040) contains a short segment B<<613.0,293.0>-<612.0,275.0>-<612.0,267.5>>

    • at (U+0040) contains a short segment B<<612.0,267.5>-<612.0,260.0>-<612.0,257.0>>

    • M (U+004D) contains a short segment L<<177.0,626.0>--<173.0,626.0>>

    • M (U+004D) contains a short segment L<<450.0,129.0>--<454.0,129.0>>

    • N (U+004E) contains a short segment L<<176.0,593.0>--<172.0,593.0>>

    • N (U+004E) contains a short segment L<<582.0,123.0>--<586.0,123.0>>

    • Q (U+0051) contains a short segment B<<416.0,-9.0>-<410.0,-9.0>-<403.5,-9.5>>

    • Q (U+0051) contains a short segment B<<403.5,-9.5>-<397.0,-10.0>-<391.0,-10.0>>

    • W (U+0057) contains a short segment B<<468.0,577.5>-<463.0,600.0>-<461.0,609.0>>

    • 62 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • uniFD3E (U+FD3E): L<<272.0,409.0>--<273.0,459.0>> -> L<<273.0,459.0>--<273.0,583.0>> [code: found-colinear-vectors]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Ukrainian (Cyrl, 29,273,587 speakers), Aghem (Latn, 38,843 speakers), Igbo (Latn, 27,823,640 speakers), Basaa (Latn, 332,940 speakers), Navajo (Latn, 166,319 speakers), Belarusian (Cyrl, 10,064,517 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notosansnko/NotoSansNKo-Regular.ttf
Dehinted Size 53.6kb
Hinted Size 77.8kb
Increase 24.2kb
Change 45.1 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.004; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notosansnko [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 1 10 66 7 165 0
0% 0% 4% 27% 3% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner self-requested a review September 5, 2023 16:23
@RosaWagner RosaWagner merged commit b359da9 into main Sep 6, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_notosansnko branch September 6, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

2 participants