Noto Sans Syloti Nagri: Version 2.004; ttfautohint (v1.8.4.7-5d5b) added

[simoncozens]

1447760: [gftools-packager] Noto Sans Syloti Nagri: Version 2.004; ttfautohint (v1.8.4.7-5d5b) added

• Noto Sans Syloti Nagri Version 2.004; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/notofonts/syloti-nagri.git at commit https://github.com/notofonts/syloti-nagri/commit/.

[github-actions]

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks

ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

• ℹ INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

  And these are the most common STAT axis orderings:
  [code: summary]

[15] NotoSansSylotiNagri-Regular.ttf

🔥 FAIL: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)

• 🔥 FAIL The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́ [code: soft-dotted]

⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

• ⚠ WARN The following codepoints supported by the font are not covered by
  any subsets defined in the font's metadata file, and will never
  be served. You can solve this by either manually adding additional
  subset declarations to METADATA.pb, or by editing the glyphset
  definitions.

• U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi

• U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

• U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

• U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

• U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, math, tifinagh, coptic

• U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

• U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, math, tai-le, malayalam, old-permic, canadian-aboriginal, coptic, syriac

• U+030A COMBINING RING ABOVE: try adding syriac

• U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

• U+030C COMBINING CARON: try adding one of: cherokee, tai-le

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, syloti-nagri [code: unreachable-subsetting]

⚠ WARN: Combined length of family and style must not exceed 27 characters. (com.google.fonts/check/name/family_and_style_max_length)

• ⚠ WARN The combined length of family and style exceeds 27 chars in the following 'WINDOWS' entries:
  FONT_FAMILY_NAME = 'Noto Sans Syloti Nagri' / SUBFAMILY_NAME = 'Regular'

Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)

• ⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)

• ⚠ WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
  Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

• ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

• ⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:

  • uni00A0.1
    [code: unreachable-glyphs]

⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)

• ⚠ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2 

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)

• ⚠ WARN The most common width is 572 among a set of 6 math glyphs.
  The following math glyphs have a different width, though:

Width = 322:
minus
[code: width-outliers]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

• ℹ INFO Hinting filesize impact:

	ofl/notosanssylotinagri/NotoSansSylotiNagri-Regular.ttf
Dehinted Size	46.0kb
Hinted Size	65.7kb
Increase	19.7kb
Change	42.8 %
[code: size-impact]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

• ℹ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]

ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

• ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

• ℹ INFO Version string is: "Version 2.004; ttfautohint (v1.8.4.7-5d5b)"
  The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
  "Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

• ℹ INFO This font contains the following optional tables:

  • cvt

  • fpgm

  • loca

  • prep

  • GPOS

  • GSUB

  • gasp

  • vhea

  • vmtx [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

• ℹ INFO ofl/notosanssylotinagri [code: family-path]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	1	8	62	7	168	0
0%	0%	3%	25%	3%	68%	0%

Note: The following loglevels were omitted in this report:

• SKIP
• PASS
• DEBUG

[simoncozens]

Noto Sans Syloti Nagri v2.004 This release fixes a number of issues with attachment of accents to the dotted circle glyph. (#7)

[RosaWagner]

@simoncozens this family still shows tofu in dev-sandbox. The missing glyphs seems to be avagraha-beng (09BD)

[simoncozens]

Sample text for Syloti Nagri is still Sanskrit. I need to ask @SKing-2003 to find a new one...

[emmamarichal]

@simoncozens Did you ask for a new sample text?
I also read this issue: googlefonts/lang#105, do we need to do something there too in order to unblock this PR?

[simoncozens]

We currently have a good sample text for Syloti Nagri (syl_Sylo) and a bad one (sa_Sylo). We need to remove the bad one. I'll do that now.

[m4rc1e]

Tofus are still visible on dev server. Keeping this blocked.

[simoncozens]

This is the old sample text, which was removed from the repo in February; maybe it wasn't removed on the internal side. I'll ask eng.

[emmamarichal]

@simoncozens any update about this?

[vv-monsalve]

@simoncozens Is the change introduced in pull request #7248 the only one needed, or is something else missing? The font still shows tofu on the development server even though that pull request has been merged.

[simoncozens]

Putting the changed language in the push lists should do it, although eng may also need to repush the font afterwards, I'm not sure.

[chrissimpkins]

@nyshadhr9 possible to weigh in on the process that we need to follow here?

[nyshadhr9]

I deleted sa_Sylo from dev and the specimen page now seems to be displaying the correct sample text.

[vv-monsalve]

Thanks @nyshadhr9. I can confirm it looks okay now in dev-server

Edit: it's working ok now in Sandbox