Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Sans Khudawadi: fixed lang issue in METADATA.pb #6647

Closed
wants to merge 1 commit into from

Conversation

RosaWagner
Copy link
Contributor

fixes #6612 and unblock #6563

@RosaWagner RosaWagner added the I Lang languages and sample texts label Aug 30, 2023
@github-actions
Copy link

FontBakery report

fontbakery version: 0.9.0a2

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[17] NotoSansKhudawadi-Regular.ttf
🔥 FAIL: Version number has increased since previous release on Google Fonts? (com.google.fonts/check/version_bump)
  • 🔥 FAIL Version number 2.0030059814453125 is equal to version on Google Fonts.
  • 🔥 FAIL Version number 2.0030059814453125 is equal to version on Google Fonts GitHub repo.
🔥 FAIL: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • 🔥 FAIL Font can't render "sd_Khud" sample text:
    "𑋝𑋗𑋛𑋙𑋠 𑊰𑋑𑋝𑋠𑋑 𑊱𑋂𑋩𑋠𑋏 𑊲 𑊰𑋂𑋩𑋍 𑊲 𑋞𑊺𑋩𑋑 ڄ𑋘 𑋞𑋛𑋠𑋚𑋘 ڪ𑊰𑋑 𑋑𑋙𑋠𑋑𑋙 𑋒𑋘𑋏𑋠ٿ𑋘𑋠 𑊱𑋞𑋑। 𑊰𑋑𑋞𑋑"
    [code: sample-text]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, cherokee, coptic

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh

  • U+0307 COMBINING DOT ABOVE: try adding one of: malayalam, canadian-aboriginal, coptic, tifinagh, old-permic, tai-le, math, syriac

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le

Or you can add the above codepoints to one of the subsets supported by the font: khudawadi, latin, latin-ext, menu [code: unreachable-subsetting]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
  • WARN The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently. [code: description-not-updated]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • emdash

    • endash

    • uni00A0.1
      [code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

- Glyph name: aogonek	Contours detected: 3	Expected: 2

- Glyph name: uogonek	Contours detected: 2	Expected: 1

[code: contour-count]

WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 572 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 322:
minus
[code: width-outliers]

WARN: Are any segments inordinately short? (com.google.fonts/check/outline_short_segments)
  • WARN The following glyphs have segments which seem very short:

    • two (U+0032) contains a short segment L<<159.0,84.0>--<159.0,80.0>>

    • at (U+0040) contains a short segment B<<613.0,293.0>-<612.0,275.0>-<612.0,267.5>>

    • at (U+0040) contains a short segment B<<612.0,267.5>-<612.0,260.0>-<612.0,257.0>>

    • M (U+004D) contains a short segment L<<177.0,626.0>--<173.0,626.0>>

    • M (U+004D) contains a short segment L<<450.0,129.0>--<454.0,129.0>>

    • N (U+004E) contains a short segment L<<176.0,593.0>--<172.0,593.0>>

    • N (U+004E) contains a short segment L<<582.0,123.0>--<586.0,123.0>>

    • Q (U+0051) contains a short segment B<<416.0,-9.0>-<410.0,-9.0>-<403.5,-9.5>>

    • Q (U+0051) contains a short segment B<<403.5,-9.5>-<397.0,-10.0>-<391.0,-10.0>>

    • W (U+0057) contains a short segment B<<468.0,577.5>-<463.0,600.0>-<461.0,609.0>>

    • 90 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-short-segments]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ i̒ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ i̦̒ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ i̧̒ ĵ

Your font does not cover the following languages that require the soft-dotted feature: Belarusian (Cyrl, 10,064,517 speakers), Basaa (Latn, 332,940 speakers), Navajo (Latn, 166,319 speakers), Lithuanian (Latn, 2,357,094 speakers), Aghem (Latn, 38,843 speakers), Dutch (Latn, 31,709,104 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Igbo (Latn, 27,823,640 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notosanskhudawadi/NotoSansKhudawadi-Regular.ttf
Dehinted Size 49.9kb
Hinted Size 69.0kb
Increase 19.1kb
Change 38.3 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.003; ttfautohint (v1.8.4.7-5d5b)"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notosanskhudawadi [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 2 9 63 7 166 0
0% 1% 4% 26% 3% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner
Copy link
Contributor Author

cc @simoncozens
We expect tofu in sandbox

🔥 FAIL: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
🔥 FAIL Font can't render "sd_Khud" sample text:
"𑋝𑋗𑋛𑋙𑋠 𑊰𑋑𑋝𑋠𑋑 𑊱𑋂𑋩𑋠𑋏 𑊲 𑊰𑋂𑋩𑋍 𑊲 𑋞𑊺𑋩𑋑 ڄ𑋘 𑋞𑋛𑋠𑋚𑋘 ڪ𑊰𑋑 𑋑𑋙𑋠𑋑𑋙 𑋒𑋘𑋏𑋠ٿ𑋘𑋠 𑊱𑋞𑋑। 𑊰𑋑𑋞𑋑"
[code: sample-text]

@RosaWagner RosaWagner added the -- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) label Aug 30, 2023
@RosaWagner
Copy link
Contributor Author

apparently sd_Khud should be renamed sd_Sind so closing this PR…

@RosaWagner RosaWagner closed this Aug 30, 2023
@RosaWagner RosaWagner deleted the notosanskhudawadi-lang branch August 30, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs lang/glyphset update Missing glyphs in .nam or sample text (not a font issue) I Lang languages and sample texts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant