Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workbench: Version 2.000;gftools[0.9.33] added #6917

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Workbench: Version 2.000;gftools[0.9.33] added #6917

merged 4 commits into from
Nov 15, 2023

Conversation

vv-monsalve
Copy link
Collaborator

2690e14: [gftools-packager] Workbench: Version 2.000;gftools[0.9.33] added

@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@vv-monsalve vv-monsalve marked this pull request as draft October 26, 2023 22:26
@vv-monsalve vv-monsalve linked an issue Oct 26, 2023 that may be closed by this pull request
Add Homecomputer VF fonts #3425
Closed
7 tasks
This was referenced Oct 26, 2023
Merged
Merged
@vv-monsalve
Copy link
Collaborator Author

Updated

Workbench: Version 2.000 added

f45a382: [gftools-packager] Workbench: Version 2.000 added

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

FontBakery report

fontbakery version: 0.10.3

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Kernel/kl_Latn (Kalaallisut): [FAIL: Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̊] [code: failed-language-shaping]
  • 🔥 FAIL GF_Latin_Kernel/zu_Latn (Zulu): [FAIL: Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̄, ◌̆, ◌̈, ◌̊, ◌̧] [code: failed-language-shaping]

[1] Family checks
ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

  • ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('SCAN-BLED', 1) [code: summary]


[16] Workbench[BLED,SCAN].ttf
🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)

  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x0300 (COMBINING GRAVE ACCENT)

    • 0x0301 (COMBINING ACUTE ACCENT)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0304 (COMBINING MACRON)

    • 0x02D9 (DOT ABOVE)

    • 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)

    • 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 119 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
  • 🔥 FAIL Compulsory STAT Axis Values are incorrect:
Name Axis Current Value Current Flags Current LinkedValue Expected Value Expected Flags Expected LinkedValue
Regular wght N/A N/A N/A 400.0 0 700.0
[code: bad-axis-values]
🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
  • 🔥 FAIL fvar instances are incorrect:
  • Delete additional instances
Name current expected
Overexposed SCAN=67.0, BLED=0.0 N/A
Evenly SCAN=-27.0, BLED=0.0 N/A
Overlapping SCAN=37.0, BLED=0.0 N/A
Touching SCAN=21.0, BLED=0.0 N/A
Slight SCAN=-45.0, BLED=0.0 N/A
Delicate SCAN=-53.0, BLED=0.0 N/A
Maximum SCAN=100.0, BLED=0.0 N/A
Regular SCAN=0.0, BLED=0.0 SCAN=0.0, BLED=0.0
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • 🔥 FAIL The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 1024 when it should be at least 1228 [code: bad-hhea-range]
🔥 FAIL: Validate METADATA.pb axes tags are defined in gf_axisregistry. (com.google.fonts/check/metadata/gf_axisregistry_valid_tags)
  • 🔥 FAIL The font variation axis 'BLED' is not yet registered on Google Fonts Axis Registry. [code: bad-axis-tag]
  • 🔥 FAIL The font variation axis 'SCAN' is not yet registered on Google Fonts Axis Registry. [code: bad-axis-tag]
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • ⚠ WARN It seems that Jens Kutílek is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • ℹ INFO Hinting filesize impact:
ofl/workbench/Workbench[BLED,SCAN].ttf
Dehinted Size 31.7kb
Hinted Size 31.7kb
Increase 24 bytes
Change 0.1 %
[code: size-impact]
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000'] [code: version-not-detected]
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • ℹ INFO Version string is: "Version 2.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
ℹ INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • ℹ INFO Latn [code: dlng-tag]
  • ℹ INFO Latn [code: slng-tag]
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

  • ℹ INFO This font contains the following optional tables:

    • loca

    • prep

    • GSUB

    • gasp [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • ℹ INFO ofl/workbench [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 7 1 55 10 182 0
0% 3% 0% 22% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Nov 2, 2023 •
edited
Loading

  • 🔥 FAIL: Does DESCRIPTION file contain broken links?

The link will exist when #6919 is merged. We should remember to counter-check the link once in prod.

  • 🔥 FAIL: Check Google Fonts glyph coverage.
  • 🔥 FAIL: Check font follows the Google Fonts vertical metric schema

Due to the historical origin of the fonts, it was agreed to accept these fails.

  • 🔥 FAIL: Check variable font instances

Given the font only includes custom axes, it is accepted for them to include custom-named instances. After Kablammo's case, this was confirmed for the homecomputer fonts. I need to include this in the GF-Guide

  • 🔥 FAIL: Check a font's STAT table contains compulsory Axis Values.

Bug reported in googlefonts/axisregistry#99 (comment)

  • 🔥 FAIL: Validate METADATA.pb axes tags are defined in gf_axisregistry.

The SCAN and BLED axes were already merged in the googlefonts/axisregistry repo and will be brought with an upcoming git subtree pull. Please only merge this PR once I create that git subtree pull. I'll inform you about it

  • ⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog?

Jens Kutílek bio info was added in #6935

@vv-monsalve vv-monsalve marked this pull request as ready for review November 2, 2023 22:26
@vv-monsalve vv-monsalve added -- Requires Axis Registration Variable axes are not yet registered I New Font labels Nov 2, 2023
@vv-monsalve vv-monsalve mentioned this pull request Nov 9, 2023
Merged
3 tasks
@vv-monsalve vv-monsalve removed the -- Requires Axis Registration Variable axes are not yet registered label Nov 9, 2023
@github-actions GitHub Actions
Copy link

FontBakery report

fontbakery version: 0.10.3

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Kernel/kl_Latn (Kalaallisut): [FAIL: Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̊] [code: failed-language-shaping]
  • 🔥 FAIL GF_Latin_Kernel/zu_Latn (Zulu): [FAIL: Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̄, ◌̆, ◌̈, ◌̊, ◌̧] [code: failed-language-shaping]

[1] Family checks
ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

  • ℹ INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('SCAN-BLED', 1) [code: summary]


[16] Workbench[BLED,SCAN].ttf
🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)

  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x0300 (COMBINING GRAVE ACCENT)

    • 0x0301 (COMBINING ACUTE ACCENT)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0304 (COMBINING MACRON)

    • 0x02D9 (DOT ABOVE)

    • 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)

    • 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 119 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
  • 🔥 FAIL Compulsory STAT Axis Values are incorrect:
Name Axis Current Value Current Flags Current LinkedValue Expected Value Expected Flags Expected LinkedValue
Regular wght N/A N/A N/A 400.0 0 700.0
[code: bad-axis-values]
🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
  • 🔥 FAIL fvar instances are incorrect:
  • Delete additional instances
Name current expected
Overexposed SCAN=67.0, BLED=0.0 N/A
Evenly SCAN=-27.0, BLED=0.0 N/A
Touching SCAN=21.0, BLED=0.0 N/A
Delicate SCAN=-53.0, BLED=0.0 N/A
Maximum SCAN=100.0, BLED=0.0 N/A
Slight SCAN=-45.0, BLED=0.0 N/A
Overlapping SCAN=37.0, BLED=0.0 N/A
Regular SCAN=0.0, BLED=0.0 SCAN=0.0, BLED=0.0
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • 🔥 FAIL The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 1024 when it should be at least 1228 [code: bad-hhea-range]
🔥 FAIL: Validate METADATA.pb axes tags are defined in gf_axisregistry. (com.google.fonts/check/metadata/gf_axisregistry_valid_tags)
  • 🔥 FAIL The font variation axis 'BLED' is not yet registered on Google Fonts Axis Registry. [code: bad-axis-tag]
  • 🔥 FAIL The font variation axis 'SCAN' is not yet registered on Google Fonts Axis Registry. [code: bad-axis-tag]
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • ⚠ WARN It seems that Jens Kutílek is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • ℹ INFO Hinting filesize impact:
ofl/workbench/Workbench[BLED,SCAN].ttf
Dehinted Size 31.7kb
Hinted Size 31.7kb
Increase 24 bytes
Change 0.1 %
[code: size-impact]
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000'] [code: version-not-detected]
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • ℹ INFO Version string is: "Version 2.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
ℹ INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • ℹ INFO Latn [code: dlng-tag]
  • ℹ INFO Latn [code: slng-tag]
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

  • ℹ INFO This font contains the following optional tables:

    • loca

    • prep

    • GSUB

    • gasp [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • ℹ INFO ofl/workbench [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 7 1 55 10 182 0
0% 3% 0% 22% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner
Copy link
Contributor

@vv-monsalve the "regular" instance correspond to the "close" location but is called "regular" in the FVAR table
Screenshot 2023-11-15 at 14 31 15

@RosaWagner RosaWagner added the -- Needs confirmation from upstream or onboarder label Nov 15, 2023
@RosaWagner
Copy link
Contributor

After discussing the axes with @vv-monsalve, we decided to merge the PR so see how they render in sandbox but she would make a new PR where "Close" is elided in the STAT table for better cross-platform naming consistency.

@RosaWagner RosaWagner removed the -- Needs confirmation from upstream or onboarder label Nov 15, 2023
@RosaWagner RosaWagner merged commit 16ac25b into main Nov 15, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_workbench branch November 15, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmamarichal emmamarichal emmamarichal left review comments

@RosaWagner RosaWagner RosaWagner approved these changes

Assignees
No one assigned
Labels
I New Font
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Homecomputer VF fonts
3 participants
@vv-monsalve @RosaWagner @emmamarichal