Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sixtyfour: Version 2.001 added #7025

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Conversation

vv-monsalve
Copy link
Collaborator

e0fab0e: [gftools-packager] Sixtyfour: Version 2.001 added

@vv-monsalve vv-monsalve linked an issue Nov 28, 2023 that may be closed by this pull request
7 tasks

This comment was marked as outdated.

@vv-monsalve
Copy link
Collaborator Author

@RosaWagner This PR updates Sixtyfour, following what was described in #6919-comment

Copy link

FontBakery report

fontbakery version: 0.10.4

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Kernel glyphset:
Language FAIL messages
kl_Latn (Kalaallisut) Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̊
zu_Latn (Zulu) Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̄, ◌̆, ◌̈, ◌̊, ◌̧

[code: failed-language-shaping]


[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('SCAN-BLED', 1) [code: summary]


[17] Sixtyfour[BLED,SCAN].ttf
🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x0300 (COMBINING GRAVE ACCENT)

    • 0x0301 (COMBINING ACUTE ACCENT)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0304 (COMBINING MACRON)

    • 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)

    • 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 117 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
  • 🔥 FAIL Compulsory STAT Axis Values are incorrect:
Name Axis Current Value Current Flags Current LinkedValue Expected Value Expected Flags Expected LinkedValue
Regular wght N/A N/A N/A 400.0 0 700.0
[code: bad-axis-values]
🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
  • 🔥 FAIL fvar instances are incorrect:
  • Add missing instances
  • Delete additional instances
Name current expected
Touching SCAN=21.0, BLED=0.0 N/A
Close SCAN=0.0, BLED=0.0 N/A
Overlapping SCAN=37.0, BLED=0.0 N/A
Maximum SCAN=100.0, BLED=0.0 N/A
Evenly SCAN=-27.0, BLED=0.0 N/A
Overexposed SCAN=67.0, BLED=0.0 N/A
Slight SCAN=-45.0, BLED=0.0 N/A
Delicate SCAN=-53.0, BLED=0.0 N/A
Regular N/A SCAN=0.0, BLED=0.0
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • 🔥 FAIL The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 1024 when it should be at least 1228 [code: bad-hhea-range]
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
  • 🔥 FAIL On the font variation axis 'SCAN', the name 'Delicate' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'SCAN', the name 'Slight' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'SCAN', the name 'Evenly' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'SCAN', the name 'Close' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'SCAN', the name 'Touching' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'SCAN', the name 'Overlapping' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'SCAN', the name 'Overexposed' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'SCAN', the name 'Maximum' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'BLED', the name 'Moderate' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
  • 🔥 FAIL On the font variation axis 'BLED', the name 'Strong' is not among the expected ones (Default) according to the Google Fonts Axis Registry. [code: invalid-name]
🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to a name ID whose string is equal to the string of either name ID 2 or 17, and its postScriptNameID value is set to a name ID whose string is equal to the string of name ID 6. (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Close' instance has the same coordinates as the default instance; its subfamily name should be 'Regular' [code: invalid-default-instance-subfamily-name]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+2021 DOUBLE DAGGER: try adding adlam

  • U+2030 PER MILLE SIGN: try adding adlam

  • U+2126 OHM SIGN: not included in any glyphset definition

  • U+2501 BOX DRAWINGS HEAVY HORIZONTAL: not included in any glyphset definition

  • U+2503 BOX DRAWINGS HEAVY VERTICAL: not included in any glyphset definition

  • U+250F BOX DRAWINGS HEAVY DOWN AND RIGHT: not included in any glyphset definition

  • U+2513 BOX DRAWINGS HEAVY DOWN AND LEFT: not included in any glyphset definition

  • U+2517 BOX DRAWINGS HEAVY UP AND RIGHT: not included in any glyphset definition

  • U+251B BOX DRAWINGS HEAVY UP AND LEFT: not included in any glyphset definition
    200 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/sixtyfour/Sixtyfour[BLED,SCAN].ttf
Dehinted Size 69.8kb
Hinted Size 69.9kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.001'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.001"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • INFO Latn [code: dlng-tag]
  • INFO Latn [code: slng-tag]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/sixtyfour [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 8 1 56 10 180 0
0% 3% 0% 22% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner
Copy link
Contributor

RosaWagner commented Nov 29, 2023

🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to a name ID whose string is equal to the string of either name ID 2 or 17, and its postScriptNameID value is set to a name ID whose string is equal to the string of name ID 6. (com.adobe.fonts/check/varfont/valid_default_instance_nameids)

I don't think it is necessary to solve this check but it highlights a small conflict in the display of the style name of the default instance, so just as info:

  • In Fontbook (Mac): "Regular"
  • In TextEdit (Mac): "Regular"
  • In Indesign (Mac): "Close"
  • In Words (Mac): "Close" (2 times)
  • In font dir (Windows): "Close"
  • In Words (Windows): "Close"

So Adobe and Windows are both displaying the font (family name + style name) as we expect, but native apps from Mac are not. Which I don't think is the end of the world tbh; no issue were reported with Kablammo so far. A way to solve this would be to have the master origin called "Close" instead of Regular but I have no idea if the API would actually like it. Maybe that is a conversation to have with the eng team next year for future projects without weight axes.

@RosaWagner RosaWagner merged commit a44c507 into main Nov 29, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_sixtyfour branch November 29, 2023 12:09
@vv-monsalve
Copy link
Collaborator Author

Thanks for the detailed note. Yes, we'll need to find a final resolution for fonts with only custom axes. Eventually, if following the last option (to which I agree) we'll need to adjust the build & test tools to accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Homecomputer VF fonts
2 participants