Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS Article refactored #7027

Merged
merged 3 commits into from
Nov 29, 2023
Merged

PPS Article refactored #7027

merged 3 commits into from
Nov 29, 2023

Conversation

vv-monsalve
Copy link
Collaborator

Hi @chrissimpkins, following what we discussed today, as well as taking one previous font including an Article as a referent, I've rearranged the entire About section to give a better structure doing the following:

  • Add the "standard" (less editorial) description at the top of the article.
  • Including an <hr> element to divide the before from the Article text
  • Attempting to add a heading for the Article
  • Rearrange the text to move the mention of the Emojis under a subsection dedicated to them
  • Adding the list of the available emojis.
  • Final round on spell check grammar and turn it into third person.

@vv-monsalve
Copy link
Collaborator Author

@RosaWagner I think #7006 (the PR that is updating the font) should be merged first so this Article update overrides the Article included there.

@RosaWagner
Copy link
Contributor

There will be some conflict so I gonna do some little tweaks to the first PR so I can merge this one after.

@RosaWagner RosaWagner merged commit dea6e04 into main Nov 29, 2023
9 checks passed
@RosaWagner RosaWagner deleted the PPS-About-update branch November 29, 2023 11:09
@vv-monsalve
Copy link
Collaborator Author

Changes included here are included and updated in #7041

@eliheuer
Copy link
Collaborator

eliheuer commented Dec 5, 2023

This PR is being tracked through production here: #7041

@vv-monsalve
Copy link
Collaborator Author

I believe this was already stated in my previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants