Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playpen: Emoji subset added to metadata #7032

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

vv-monsalve
Copy link
Collaborator

@vv-monsalve vv-monsalve commented Nov 29, 2023

Changing subset symbols to emoji to #7006.

@RosaWagner The PR updating the font was merged this morning. In cases like these small quick fixes, should we add the METADATA label to this PR in any case?

Edit: Not adding labels to only track the changes through the font's PR linked above.

Copy link

FontBakery report

fontbakery version: 0.10.4

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Core glyphset:
Language FAIL messages
fo_Latn (Faroese) Shaper didn't attach uni0335.case to E
is_Latn (Icelandic) Shaper didn't attach uni0335.case to E.alt1
teo_Latn (Teso) Some base glyphs were missing: Ɔ, Ɛ, Ɨ, Ʉ, ɔ, ɛ, ɨ, ʉ, ᵃ, ᵉ, ᵋ, ᵒ, ᵓ, ᵘ, ᶤ, ᶶ, ⁱ
^ Shaper produced a .notdef

[code: failed-language-shaping]

  • WARN GF_Latin_Core glyphset:
Language FAIL messages
lg_Latn (Ganda) No variant glyphs were found for Eng
dyo_Latn (Jola-Fonyi) No variant glyphs were found for Eng
ny_Latn (Nyanja) No variant glyphs were found for Eng
wo_Latn (Wolof) No variant glyphs were found for Eng

[code: warning-language-shaping]


[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[14] PlaypenSans[wght].ttf
🔥 FAIL: Check for METADATA subsets with zero support. (com.google.fonts/check/metadata/unsupported_subsets)
  • 🔥 FAIL Please remove the unrecognized subset 'emoji' from the METADATA.pb file. [code: unknown-subset]
🔥 FAIL: Check METADATA.pb includes production subsets. (com.google.fonts/check/metadata/includes_production_subsets)
  • 🔥 FAIL The following subsets are missing [symbols] [code: missing-subsets]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, yi, canadian-aboriginal

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

  • U+030A COMBINING RING ABOVE: try adding syriac

  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
    41 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: emoji, latin, latin-ext, math, menu, vietnamese [code: unreachable-subsetting]

WARN: Check if category on METADATA.pb matches what can be inferred from the family name. (com.google.fonts/check/metadata/category_hints)
  • WARN Familyname seems to hint at "SANS_SERIF" but METADATA.pb declares it as "['HANDWRITING']". [code: inferred-category]
WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)
  • WARN This font has a 'Soft Hyphen' character. [code: softhyphen]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters should disappear in other cases, for example: į̛̀ į̛́ į̛̂ į̛̃ į̛̄ į̛̆ į̛̇ į̛̈ į̛̉ į̛̊ į̛̋ į̛̌ į̛̒ į̣̀ į̣́ į̣̂ į̣̃ į̣̄ į̣̆ į̣̇

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Ma’di (Latn, 584,000 speakers), Ebira (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Navajo (Latn, 166,319 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Kom (Latn, 360,685 speakers), Dan (Latn, 1,099,244 speakers), Mango (Latn, 77,000 speakers), Sar (Latn, 500,000 speakers), Aghem (Latn, 38,843 speakers), Basaa (Latn, 332,940 speakers), Gulay (Latn, 250,478 speakers), Nateni (Latn, 100,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ejagham (Latn, 120,000 speakers), Avokaya (Latn, 100,000 speakers), Koonzime (Latn, 40,000 speakers), Lugbara (Latn, 2,200,000 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/playpensans/PlaypenSans[wght].ttf
Dehinted Size 505.0kb
Hinted Size 505.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.002'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.002"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • INFO Latn [code: dlng-tag]
  • INFO Latn [code: slng-tag]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/playpensans [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 3 4 52 9 187 0
0% 1% 2% 20% 4% 73% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner
Copy link
Contributor

@vv-monsalve Can't we include symbols and emoji? I am thinking of the arrows or other codepoints that could be related to symbols

@RosaWagner
Copy link
Contributor

(I usually add the proper label to know what this PR is about, and then remove from the project board manually if another PR is already tracked)

@vv-monsalve vv-monsalve merged commit 2bede8b into main Nov 29, 2023
9 checks passed
@vv-monsalve vv-monsalve deleted the PPS-emoji-metadata branch November 29, 2023 20:03
@vv-monsalve
Copy link
Collaborator Author

I accidentally merged the metadata PR before finishing reading your comments. I had the doubt about deleting "Symbols". I'll reinstate it in another PR.

@vv-monsalve vv-monsalve restored the PPS-emoji-metadata branch November 29, 2023 20:08
@vv-monsalve
Copy link
Collaborator Author

Actually, checking at the font again the codepoints that would require "symbols" are the same ones that would be covered by "emoji".

@eliheuer
Copy link
Collaborator

eliheuer commented Dec 5, 2023

This PR is being tracked through production here: #7041

@RosaWagner RosaWagner changed the title Emoji subset added to PPS metadata Playpen: Emoji subset added to metadata Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants