Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tags_metadata.csv #8526

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Create tags_metadata.csv #8526

merged 1 commit into from
Nov 21, 2024

Conversation

nyshadhr9
Copy link
Collaborator

No description provided.

@nyshadhr9 nyshadhr9 merged commit 544b09e into main Nov 21, 2024
8 checks passed
@nyshadhr9 nyshadhr9 deleted the nyshadhr9-patch-5 branch November 21, 2024 02:11
@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 21, 2024

@nyshadhr9 Any reason why we need a separate file? Since I have been developing the app to input the tagging data, I would like to be involved in these decisions, or at least informed that breaking changes are incoming,.

@nyshadhr9
Copy link
Collaborator Author

This is a list of all the tags and their display names. Going forward lets add new tags here and that helps us internally to run checks like not having an invalid or misspelled tag for a family. This could be expanded further to add additional metadata about tags but we don't have any concrete plans yet.

I also added a tags_ui_details file and thats specifically for the frontend catalog. Having it in the github repo helps in surfacing tags on dev frontend. No action needed there.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 21, 2024

Thanks for the explanation. I'll update https://google.github.io/fonts/tags.html so it'll also modify this file if a user adds a tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants