fsync set policy ioctls #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
irq0
force-pushed
the
wip/fsync-fscrypt-ioctls
branch
from
95f1347
to
ae7dded
Compare
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Aug 12, 2022
Remove if google/fscrypt#359 gets accepted
ebiggers
reviewed
Aug 12, 2022
Split policyIoctl into setPolicyIoctl and getPolicyIoctl. Add a os.Sync() call to setPolicyIoctl. Policy ioctls are not necessary durable on return. For example, on ext4 (ref: fs/ext4/crypto.c: ext4_set_context) they are not. This may lead to a filesystem containing fscrypt metadata (in .fscrypt), but without the policy applied on an encrypted directory. Example: Snapshotting a mounted ext4 filesystem on Ceph RBD right after setting the policy. While subject to timing, with high probability the snapshot will not have the policy set. Calling fsync fixes this. Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
irq0
force-pushed
the
wip/fsync-fscrypt-ioctls
branch
from
ae7dded
to
e3746be
Compare
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Aug 17, 2022
Remove if google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
|
The failure in "Run command-line interface tests" is unrelated and will be fixed by #362. So it looks like you just need to sign the CLA. (Or make sure that you've done everything for the CLA to be recognized, if your company already has it on file.) |
There is already a company CLA, I'm waiting to get added. |
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Aug 19, 2022
Remove if google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
|
CLA is now signed |
ebiggers
approved these changes
Aug 23, 2022
|
Merged, thanks! |
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Aug 24, 2022
Revert once our google/fscrypt dependency is upgraded to a version that includes google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Aug 24, 2022
Revert once our google/fscrypt dependency is upgraded to a version that includes google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Aug 30, 2022
Revert once our google/fscrypt dependency is upgraded to a version that includes google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Sep 6, 2022
Revert once our google/fscrypt dependency is upgraded to a version that includes google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Sep 20, 2022
Revert once our google/fscrypt dependency is upgraded to a version that includes google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Sep 26, 2022
Revert once our google/fscrypt dependency is upgraded to a version that includes google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Oct 13, 2022
Revert once our google/fscrypt dependency is upgraded to a version that includes google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
irq0
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Oct 14, 2022
Revert once our google/fscrypt dependency is upgraded to a version that includes google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
Madhu-1
pushed a commit
to irq0/ceph-csi
that referenced
this pull request
Oct 17, 2022
Revert once our google/fscrypt dependency is upgraded to a version that includes google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
mergify bot
pushed a commit
to ceph/ceph-csi
that referenced
this pull request
Oct 17, 2022
Revert once our google/fscrypt dependency is upgraded to a version that includes google/fscrypt#359 gets accepted Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split policyIoctl into setPolicyIoctl and getPolicyIoctl. Add a
os.Sync() call to setPolicyIoctl.
Policy ioctls are not necessary durable on return. For example, on
ext4 (ref: fs/ext4/crypto.c: ext4_set_context) they are not. This may
lead to a filesystem containing fscrypt metadata (in .fscrypt), but
without the policy applied on an encrypted directory.
Example:
Snapshotting a mounted ext4 filesystem on Ceph RBD right after
setting the policy. While subject to timing, with high probability the
snapshot will not have the policy set. Calling fsync fixes this.
Signed-off-by: Marcel Lauhoff marcel.lauhoff@suse.com