Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include DMA_BUF regardless of kernel version #10

Closed
wants to merge 2 commits into from

Conversation

hibby50
Copy link

@hibby50 hibby50 commented Apr 20, 2023

This is causing issues compiling on LTS kernels. In my case SUSE 15.5 has a kernel version of 5.14 but backports whatever broke this in the first place.

@google-cla
Copy link

google-cla bot commented Apr 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chrBrd
Copy link
Contributor

chrBrd commented May 12, 2023

@hibby50

I'm not associated with Google or the maintainer of this repository, but I am hoping to maintain the contents of this repo for openSUSE!

I'm afraid to say, however, I don't think the maintainer of this GH repo should accept this PR, and you should consider closing it...

Those conditional checks are there because the changes to the dma-buf namespace that necessitated it weren't implemented until kernel 5.16. That conditional check must be there for general use and backwards compatibility etc. Upstream can't be held responsible for any issues introduced by third-party backports.

However, things like that are very much the job of hopeful maintainers. And in that capacity your issue and the associated fix are right on the money! 😁

So I've incorporated your patch into the package builds for Leap/SLES 15.5. 'Experimental' "hardware" repository. Hopefully that's okay with you? 🙂

I'm aiming to have this become part of the official openSUSE/SLES repositories very soon.

@hibby50
Copy link
Author

hibby50 commented May 12, 2023

Thank you @chrBrd that all makes sense. I am going to close this PR in favor of a SUSE maintained version.

Your OBS setup for this is also a lot prettier than mine haha

@hibby50 hibby50 closed this May 12, 2023
@cyqsimon
Copy link

cyqsimon commented Sep 5, 2023

This will be fixed by #16 (I think), just posting to notify everybody.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants