fixup gasket-1.0 build error with mainline kerenl 5.16 (aarch64) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error message: DKMS make.log for gasket-1.0 for kernel 5.16.0-rc2 (aarch64) Fri Dec 17 14:56:02 CST 2021 make: Entering directory '/usr/src/linux-headers-5.16.0-rc2' CC [M] /var/lib/dkms/gasket/1.0/build/gasket_core.o CC [M] /var/lib/dkms/gasket/1.0/build/gasket_ioctl.o CC [M] /var/lib/dkms/gasket/1.0/build/gasket_interrupt.o CC [M] /var/lib/dkms/gasket/1.0/build/gasket_page_table.o CC [M] /var/lib/dkms/gasket/1.0/build/gasket_sysfs.o CC [M] /var/lib/dkms/gasket/1.0/build/apex_driver.o LD [M] /var/lib/dkms/gasket/1.0/build/gasket.o LD [M] /var/lib/dkms/gasket/1.0/build/apex.o MODPOST /var/lib/dkms/gasket/1.0/build/Module.symvers ERROR: modpost: module gasket uses symbol dma_buf_detach from namespace DMA_BUF, but does not import it. ERROR: modpost: module gasket uses symbol dma_buf_put from namespace DMA_BUF, but does not import it. ERROR: modpost: module gasket uses symbol dma_buf_get from namespace DMA_BUF, but does not import it. ERROR: modpost: module gasket uses symbol dma_buf_unmap_attachment from namespace DMA_BUF, but does not import it. ERROR: modpost: module gasket uses symbol dma_buf_map_attachment from namespace DMA_BUF, but does not import it. ERROR: modpost: module gasket uses symbol dma_buf_attach from namespace DMA_BUF, but does not import it. make[1]: *** [scripts/Makefile.modpost:134: /var/lib/dkms/gasket/1.0/build/Module.symvers] Error 1 make[1]: *** Deleting file '/var/lib/dkms/gasket/1.0/build/Module.symvers' make: *** [Makefile:1761: modules] Error 2 make: Leaving directory '/usr/src/linux-headers-5.16.0-rc2' Signed-off-by: Yan <yan-wyb@foxmail.com>
jan-kiszka
reviewed
Feb 3, 2022
| @@ -56,6 +56,8 @@ | |||
| #include "gasket_constants.h" | |||
| #include "gasket_core.h" | |||
|
|
|||
| MODULE_IMPORT_NS(DMA_BUF); | |||
There was a problem hiding this comment.
This will need #if kernel version >= ... wrapping, or the build will break for older kernels.
I ran into that issue as well. I do have a CLA in place and will send an own PR, addressing this along that. Just that you are not surprised, @yan-wyb.
|
See @jan-kiszka 's comment - used his PR for backwards compatibility and an active CLA. Thanks for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error message:
DKMS make.log for gasket-1.0 for kernel 5.16.0-rc2 (aarch64)
Fri Dec 17 14:56:02 CST 2021
make: Entering directory '/usr/src/linux-headers-5.16.0-rc2'
CC [M] /var/lib/dkms/gasket/1.0/build/gasket_core.o
CC [M] /var/lib/dkms/gasket/1.0/build/gasket_ioctl.o
CC [M] /var/lib/dkms/gasket/1.0/build/gasket_interrupt.o
CC [M] /var/lib/dkms/gasket/1.0/build/gasket_page_table.o
CC [M] /var/lib/dkms/gasket/1.0/build/gasket_sysfs.o
CC [M] /var/lib/dkms/gasket/1.0/build/apex_driver.o
LD [M] /var/lib/dkms/gasket/1.0/build/gasket.o
LD [M] /var/lib/dkms/gasket/1.0/build/apex.o
MODPOST /var/lib/dkms/gasket/1.0/build/Module.symvers
ERROR: modpost: module gasket uses symbol dma_buf_detach from namespace DMA_BUF, but does not import it.
ERROR: modpost: module gasket uses symbol dma_buf_put from namespace DMA_BUF, but does not import it.
ERROR: modpost: module gasket uses symbol dma_buf_get from namespace DMA_BUF, but does not import it.
ERROR: modpost: module gasket uses symbol dma_buf_unmap_attachment from namespace DMA_BUF, but does not import it.
ERROR: modpost: module gasket uses symbol dma_buf_map_attachment from namespace DMA_BUF, but does not import it.
ERROR: modpost: module gasket uses symbol dma_buf_attach from namespace DMA_BUF, but does not import it.
make[1]: *** [scripts/Makefile.modpost:134: /var/lib/dkms/gasket/1.0/build/Module.symvers] Error 1
make[1]: *** Deleting file '/var/lib/dkms/gasket/1.0/build/Module.symvers'
make: *** [Makefile:1761: modules] Error 2
make: Leaving directory '/usr/src/linux-headers-5.16.0-rc2'
Signed-off-by: Yan yan-wyb@foxmail.com