Fix annotating importer address resolution. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass pointers to the perf profile proto and the main memory mapping instead of storing them as class members. * The `PerfParser` also does not need to be held on to - it is used only once. * The `PerfReader` must be held on to since it owns all of the perf related data.
…bject. * A new check of the sample PID against the main mapping PID. * Remove the check for whether the block's code was within the bounds of the executable segment in terms of file addresses, this is redundant as long as the mapping is valid.
* Previously, the annotating importer would break in certain situations, for example if the virtual address the executable segment is to be loaded at was not page-aligned.
ondrasej
reviewed
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
situations, for example if the virtual address the executable segment
is to be loaded at was not page-aligned.