-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Xbox): New backend for Xbox One #12
Conversation
This backend requires: - Xbox One device in Dev Mode - Windows 10 host - Visual Studio - Windows 10 SDK It builds a UWP (Universal Windows Platform) application hosting a WebView pointing to the desired destination URL, then deploys that app to the Xbox and launches it. In this way, it is very similar to the Tizen backend. But because this backend uses Visual Studio to build a UWP app, it **must** be run on Windows.
This updates the UA parser to one that recognizes Xbox devices including Xbox One. Corresponds to PR faisalman/ua-parser-js#479 Change-Id: I5e92e78b06c981df1659f73264b6fabfc5eb56ac
Sorry to get into the thread of the conversation. I've been looking at the code, and this really is valid for Xbox One (normal, s or x) and for Xbox Series S|X. Perhaps a better name would only be Xbox and not Xbox One. |
@avelad, I am happy to have your feedback! Perhaps you are right, but it is not usable for the original Xbox or the Xbox 360. It seems to me that Xbox {One, One X, One S, Series X, and Series S} are all running the same OS which was introduced with the Xbox One. So naming-wise, I would expect this to be the more appropriate name, and to avoid implying support for the older consoles bearing the name "Xbox". With either name, though, we should probably be very clear in the docs about which models are supported. Do you think that would be sufficient? |
Yes, maybe the name is confusing. I agree that it might be appropriate for now to keep the Xbox One name, but if you add a note of supported devices that would be great! |
<AppxBundle>Always</AppxBundle> | ||
<AppxBundlePlatforms>x64</AppxBundlePlatforms> | ||
<HoursBetweenUpdateChecks>0</HoursBetweenUpdateChecks> | ||
<PackageCertificateKeyFile>PackageCertificateKeyFile.pfx</PackageCertificateKeyFile> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the certificate needed? Although this is a random cert, it is probably not a good idea to embed any cert in a public repo. Can you just leave the app unsigned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, unfortunately, you can't leave it unsigned. I tried that. The cert was generated by VS, doesn't contain any private information, isn't tied to any entity that we own as far as I can tell, and isn't signed by anything authoritative. It's essentially a self-signed cert.
If I could figure out how to generate one from the command-line, we could drop it from the repo and add another build step. But I don't know how to do that.
Thank you! |
This backend requires:
It builds a UWP (Universal Windows Platform) application hosting a
WebView pointing to the desired destination URL, then deploys that app
to the Xbox and launches it. In this way, it is very similar to the
Tizen backend.
But because this backend uses Visual Studio to build a UWP app, it
must be run on Windows.