-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for available policies #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this, approving. Please, even in another PR if you want, a test would be awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
My only doubt is about having documentation inside the policy
package, I would rather have it in 'outputs' (even that it is not an evaluation results collector).
Changed to outputs package :) |
Apologize for broken build, already fixed it. Also changed CLI usage to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The script needs two parameters: policies folder and output file path, and it's possible to test the script locally (go run) and even test GH action locally using act
The idea here is to have a public markdown file with a list of policies to be referred from somewhere else and serve as documentation as well.
Not sure if it's the best approach, I'm open to suggestions :)