Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to bzlmod #1097

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Port to bzlmod #1097

merged 2 commits into from
Jun 8, 2024

Conversation

Vertexwahn
Copy link
Contributor

@Vertexwahn Vertexwahn commented Jun 8, 2024

This PR moves glog to Bzlmod and deletes the traditional WORKSPACE approach

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.98%. Comparing base (cd4ef77) to head (6a00c67).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1097   +/-   ##
=======================================
  Coverage   63.98%   63.98%           
=======================================
  Files          19       19           
  Lines        2563     2563           
  Branches      909      897   -12     
=======================================
  Hits         1640     1640           
- Misses        656      658    +2     
+ Partials      267      265    -2     

see 1 file with indirect coverage changes

@sergiud sergiud self-assigned this Jun 8, 2024
@sergiud sergiud added this to the 0.8 milestone Jun 8, 2024
@Vertexwahn Vertexwahn changed the title Add googletest to MODULE.bazel Port to bzlmod Jun 8, 2024
@sergiud
Copy link
Collaborator

sergiud commented Jun 8, 2024

Thanks!

@sergiud sergiud merged commit d769990 into google:master Jun 8, 2024
72 of 136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants