Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Clang-CL build with Bazel@HEAD #1131

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

meteorcloudy
Copy link
Contributor

With WORKSPACE being disabled at HEAD, all dependencies must be specified in MODULE.bazel

Fixing #1127

With WORKSPACE being disabled at HEAD, all dependencies must be specified in MODULE.bazel

Fixing google#1127
@meteorcloudy meteorcloudy changed the title Fix build with Bazel@HEAD Fix Windows Clang-CL build with Bazel@HEAD Sep 13, 2024
@drigz
Copy link
Member

drigz commented Sep 13, 2024

Thank you for the PR!

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.03%. Comparing base (b3b9eb9) to head (5606652).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1131   +/-   ##
=======================================
  Coverage   64.03%   64.03%           
=======================================
  Files          20       20           
  Lines        2580     2580           
  Branches      889      898    +9     
=======================================
  Hits         1652     1652           
  Misses        663      663           
  Partials      265      265           

@sergiud sergiud added the bug label Sep 14, 2024
@sergiud sergiud added this to the 0.8 milestone Sep 14, 2024
@sergiud sergiud merged commit be06647 into google:master Sep 14, 2024
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants