cmake: do not hardcode relative install directories #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shinh Please merge. |
|
Just curious, does this work as expected (or is at least compatible with) Windows? |
|
(I'm guessing yes, because I doubt anyone uses the |
|
It does. On Windows the commit won't make any difference. Under Linux, the correct suffix for |
durswd
pushed a commit
to durswd/glog
that referenced
this pull request
Sep 2, 2019
cmake: do not hardcode relative install directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relative install directories are determined using the CMake
GNUInstallDirsmodule. In particular, this allows to automatically determine the correctlibdirectory (libvslib64etc.).