Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert to signed int atomics #770

Merged
merged 1 commit into from
Dec 23, 2021
Merged

revert to signed int atomics #770

merged 1 commit into from
Dec 23, 2021

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Dec 22, 2021

Fixes #749

@sergiud sergiud added the bug label Dec 22, 2021
@sergiud sergiud added this to the 0.6 milestone Dec 22, 2021
@sergiud sergiud requested a review from drigz December 22, 2021 14:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #770 (eb39817) into master (4ffa983) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   72.35%   72.62%   +0.26%     
==========================================
  Files          17       17              
  Lines        3241     3240       -1     
==========================================
+ Hits         2345     2353       +8     
+ Misses        896      887       -9     
Impacted Files Coverage Δ
src/glog/logging.h.in 80.00% <100.00%> (ø)
src/logging.cc 73.32% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffa983...eb39817. Read the comment docs.

@sergiud
Copy link
Collaborator Author

sergiud commented Dec 22, 2021

@drigz LGTM analysis fails since our update to CMake 3.16. Could you please disable it for now?

@drigz
Copy link
Member

drigz commented Dec 23, 2021

Done.

@sergiud
Copy link
Collaborator Author

sergiud commented Dec 23, 2021

Thank you!

@sergiud sergiud merged commit 42d509b into master Dec 23, 2021
@sergiud sergiud deleted the log-every-n branch December 23, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOG_EVERY_N stops printing when using threads
3 participants