Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a v0.2.2 patch release #147

Closed
fejta opened this issue Sep 3, 2019 · 3 comments
Closed

Please create a v0.2.2 patch release #147

fejta opened this issue Sep 3, 2019 · 3 comments

Comments

@fejta
Copy link

fejta commented Sep 3, 2019

Will you push a v0.2.2 tag? Feel free to make this the same commit as v0.2.0, but this is necessary in order to allow people to patch update this module correctly.

https://proxy.golang.org/github.com/googleapis/gnostic/@v/list shows that at some point you published a v0.2.1,

However this no longer appears in the list of https://github.com/googleapis/gnostic tags or branches. Furthermore, it looks like golang never actually downloaded v0.2.1. Compare the following:

Thus anyone attempting to patch release a repo that uses v0.2.0 will fail, see for example:
go get -u=patch sig.k8s.io/controller-runtime

See go help goproxy and https://proxy.golang.org/ for more info.

This will cause issues for people as go 1.13 will set GOPROXY=https://proxy.golang.org GOSUMDB=sum.golang.org by default.

@timburks
Copy link
Contributor

@fejta
Copy link
Author

fejta commented Sep 10, 2019

Excellent, tried it and it seems to work thus far. Let's see if https://prow.k8s.io/?job=ci-test-infra-autoupdate-patch will pass now

@fejta
Copy link
Author

fejta commented Sep 10, 2019

Job failed but for a new reason, so I'm declaring success. Thanks!

@fejta fejta closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants