Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.3.0 or later of gnostic import #583

Closed
fejta opened this issue Sep 3, 2019 · 8 comments
Closed

Update to 0.3.0 or later of gnostic import #583

fejta opened this issue Sep 3, 2019 · 8 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@fejta
Copy link
Contributor

fejta commented Sep 3, 2019

A bad v0.2.1 release makes it impossible for people to patch upgrade controller-runtime

Repro:

$ GO111MODULE=on GOPROXY=https://proxy.golang.org GOSUMDB=sum.golang.org go get -u=patch sigs.k8s.io/controller-runtime

go: finding github.com/googleapis/gnostic v0.2.1
go get: upgrading github.com/googleapis/gnostic@v0.2.0: github.com/googleapis/gnostic@v0.2.1: reading https://proxy.golang.org/github.com/googleapis/gnostic/@v/v0.2.1.info: 410 Gone

See google/gnostic#147 for more details about why this is failing.

@fejta
Copy link
Contributor Author

fejta commented Sep 10, 2019

Fixed by #584
/close

@k8s-ci-robot
Copy link
Contributor

@fejta: Closing this issue.

In response to this:

Fixed by #584
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta
Copy link
Contributor Author

fejta commented Sep 10, 2019

/reopen

/assign @DirectXMan12

Would you be up for me pulling #584 into v0.2.0 and creating a v0.2.1 patch release with this change?

@k8s-ci-robot
Copy link
Contributor

@fejta: Reopened this issue.

In response to this:

/reopen

/assign @DirectXMan12

Would you be up for me pulling #584 into v0.2.0 and creating a v0.2.1 patch release with this change?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DirectXMan12
Copy link
Contributor

yeah, can do that now

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2019
@fejta
Copy link
Contributor Author

fejta commented Dec 9, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@fejta: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants