Update gnostic to use yaml.v3 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(requires hand-editing the generated main.go files for extensions, to-fix next)
timburks
commented
Jul 12, 2020
openapiv3/OpenAPIv3.proto
Outdated
| repeated NamedAny specification_extension = 7; | ||
| string summary = 8; | ||
| string summary = 7; | ||
| repeated NamedAny specification_extension = 8; |
There was a problem hiding this comment.
These need to be swapped back
| type_url: "type.googleapis.com/google.protobuf.StringValue" | ||
| value: "\n\00512345" | ||
| type_url: "type.googleapis.com/google.protobuf.Int64Value" | ||
| value: "\010\271`" | ||
| > |
There was a problem hiding this comment.
This test data was updated because the original was incorrect.
| @@ -47,7 +47,7 @@ | |||
| "id": "x-sampleone-mysimpleboolean" | |||
| }, | |||
| "PrimitiveInt64": { | |||
| "type": "string", | |||
There was a problem hiding this comment.
This test was incorrect.
|
This is ugly in places but all tests pass and #195 provides a fix for clients that I expect will be broken by this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes upgrades gnostic's JSON/YAML reading to use gopkg.in/yaml.v3.
In addition to having a cleaner interface, yaml.v3 maintains line and column numbers for all parsed elements, which will allow us to address #31 in a future set of changes.
This first set of commits should be enough for all tests to pass, but there are still many rough edges to be addressed before this is merged.