all: fix test lint issues detecte by tenv and thelper linters #3441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here I try to handle two kinds of issues with tests
os.Setenv
in tests that need specific env vars and we need to revert the changes in the end. This usually is done via defer + some cleanup function BUT it may not run in many cases (like in a t.Fatal) andt.Setenv
already do this and it is battle tested. for this I used the linter tenv viagitlabci-lint
.t.Helper()
in many test helpers. This was done by using the linter thelper viagitlabci-lint
. The motivation is here: https://github.com/kulti/thelper?tab=readme-ov-file#whythis should have no impact in existing code or tests, but may help identify an issue from unit tests or benchmarks