Relax Transformer name rules #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnet
force-pushed
the
transformer-name
branch
from
2e0b06b
to
4b45614
Compare
cybrcodr
approved these changes
Feb 17, 2019
Relax the Transformer name to be any Go identifier or qualified identifier. Clarify in the documentation how this is used (e.g., in Diff) and what names are valid. Fixes #102
dsnet
force-pushed
the
transformer-name
branch
from
4b45614
to
a3a8566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the Transformer name to be any Go identifier or qualified identifier.
Clarify in the documentation how this is used (e.g., in Diff) and
what names are valid.
Fixes #102