Nudge people to use custom comparers #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnet
reviewed
Feb 20, 2019
…ted options.
A common scenario is:
1. someone uses cmp.Diff on big.Int (transitively)
2. they get a message that says uses Ignore/Allow Unexported options
3. they see that AllowUnexported is hard to use correctly
4. they use IgnoreUnexported
They end up with:
cmp.IgnoreUnexported(big.Int{})
Which definitely doesn't do what's intended.
If we point out that a custom comparer is what they most likely need, then they are more likely to use cmp correctly
|
done, PTAL |
dsnet
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we put push users towards options that handle unexported fields. A common scenario is:
They end up with:
cmp.IgnoreUnexported(big.Int{})
Which definitely doesn't do what's intended.
If we point out that a custom comparer is what they most likely need, then they are more likely to use cmp correctly.