Fix ineffectual assignment to lastLineIdx #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnet
reviewed
Aug 1, 2019
Please review this thoroughly, I'm not sure I can properly test this change. However I noticed that the assignment to lastLineIdx in line 93 is ineffectual, as it'll always get overwritten in the line below. I can only assume this means we meant to assign the value to maxLineLen instead.
|
Thank you for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this thoroughly, I'm not sure I can properly test this change.
However I noticed that the assignment to lastLineIdx in line 93 is ineffectual,
as it'll always get overwritten in the line below. I can only assume this
either means the else-block was missing (which is what I'm fixing here), or it's
an old check that's just lingering around and was forgotten to be removed during
refactoring.