cmp: make retrieveUnexportedField pass Go 1.14's upcoming checkptr validation #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpvl
pushed a commit
to cuelang/cue
that referenced
this pull request
Jan 24, 2020
Currently, test is failed on go devel (at least 641e61db57) because will run checkptr when go test and which is caused by go-cmp package. It has been fixed on google/go-cmp#169, Update go-cmp package to latest release. test result: === RUN TestLiterals/0/"0" fatal error: checkptr: unsafe pointer arithmetic run: $ go get -u -d github.com/google/go-cmp@latest $ go mod tidy Change-Id: I7881e6c08fa3edb17b10b8b6f5a5e699211a9299 Reviewed-on: https://cue-review.googlesource.com/c/cue/+/4641 Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167