Limit verbosity of reporter output #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The verbosity levels could use more fine tuning, but this is good enough for now, and much better than before in my opinion. Upcoming changes:
|
cybrcodr
approved these changes
Jun 12, 2020
cmp/report_reflect.go
Outdated
|
|
||
| // PrintAddresses controls whether to print the address of all pointers, | ||
| // slice elements, and maps. | ||
| PrintAddresses bool | ||
|
|
||
| // VerbosityLevel controls the amount of amount of output to produce. | ||
| // A higher value produces more output. A value of zero or lwoer produces |
cmp/report_compare.go
Outdated
| if opts.VerbosityLevel < 0 { | ||
| return 0 | ||
| } | ||
| return uint(opts.VerbosityLevel) |
There was a problem hiding this comment.
Do you need to set a limit for this? Seems like a good number of callers for verbosity() use the return value in a shift operation. I suppose it should shift only to certain number of bits?
There was a problem hiding this comment.
I set it to a maximum of 16, which is half the width of an int on a 32-bit system.
A common complaint is that the reporter it prints out too much irrelevant information, resulting in a low signal-to-noise ratio. Improve this metric by imposing a verbosity limit. For nodes that are equal, we set the verbosity level is a lower value than when the nodes are inequal. Other minor changes: * Adjust heuristic for triple-quote usage to operate on more cases. * Elide type more aggressively for equal nodes. * Printing the address for a slice includes the length and capacity. * The pointed-at value for map keys are printed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common complaint is that the reporter it prints out too much
irrelevant information, resulting in a low signal-to-noise ratio.
Improve this metric by imposing a verbosity limit. For nodes that
are equal, we set the verbosity level is a lower value than when
the nodes are inequal.
Other minor changes: