Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change diff.Difference to always return an edit-script #45

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Change diff.Difference to always return an edit-script #45

merged 1 commit into from
Sep 28, 2017
+84 −41

Commits on Sep 28, 2017

  1. Change diff.Difference to always return an edit-script 

    Rather than performing the heuristic for whether two slices are
"too different" in the diff package, just return the full edit-script
and move the heuristic logic into the cmp package.

The main adjustment to the heuristic is that we only print the
full slice if it is composed of a slice of primitive types (e.g., []byte)
and the difference between the two slices is sufficiently great enough.

Fixes #44
    @dsnet
    dsnet committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    ee204b6 View commit details
    Browse the repository at this point in the history