Add Path.Index helper method #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I regret adding the Last method and wished I went with the Index method the first time. |
neild
approved these changes
Dec 1, 2017
| return pa.Index(-1) | ||
| } | ||
|
|
||
| // Index returns the ith step in the Path and supports negative indexing. |
There was a problem hiding this comment.
Pedantic: While anyone familiar with Python knows what negative indexing is, if you want to be precise you should define a negative index.
An analysis of user code shows that Path.Last was not sufficient and that what users really wanted was an easy want to do negative indexing without needing to constantly check for out-of-bounds. Thus, add a generic Index method that does not panic on out-of-bounds accesses and supports negative indexing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An analysis of user code shows that Path.Last was not sufficient and
that what users really wanted was an easy want to do negative indexing
without needing to constantly check for out-of-bounds.
Thus, add a generic Index method that does not panic on out-of-bounds
accesses and supports negative indexing.