Add Transform.Option helper method #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no easy way to create non-reentrant transformers where they do not recursively apply on their own output. You could check for the Transformer name, but the API does not require the names to be unique. The only way to write a helper to do this is to generate some obscure name that is guaranteed to probabilistic never have a conflict. A better approach is to simply return the original Option as returned by the Transformer constructor. Thus, users can rely on == to check if a Transform step exactly matches a Transformer that they created. It would be useful to a non-reentrant transformer to cmpopts, but that can be a future addition. It will also need a better name.
dsnet
force-pushed
the
transform-option
branch
from
7d95c04
to
8986b4c
Compare
neild
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no easy way to create non-reentrant transformers
where they do not recursively apply on their own output.
You could check for the Transformer name, but the API does not
require the names to be unique.
The only way to write a helper to do this is to generate some obscure
name that is guaranteed to probabilistic never have a conflict.
A better approach is to simply return the original Option
as returned by the Transformer constructor.
Thus, users can rely on == to check if a Transform step exactly
matches a Transformer that they created.
It would be useful to add a non-reentrant transformer to cmpopts,
but that can be a future addition. It will also need a better name.